feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Use logging category

Browse Source 
Change-Id: I0e578650201f358adbf703bc057a02e8e902aaa2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Aleksei German <aleksei.german@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
This commit is contained in:
Thomas Hartmann
2022-01-20 17:33:01 +01:00
parent 1fb54d4f2b
commit 189ff75709
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/qmldesigner/designercore/model/texttomodelmerger.cpp
View File

@@ -78,6 +78,7 @@ using namespace LanguageUtils;
using namespace QmlJS; using namespace QmlJS;
static Q_LOGGING_CATEGORY(rewriterBenchmark, "qtc.rewriter.load", QtWarningMsg) static Q_LOGGING_CATEGORY(rewriterBenchmark, "qtc.rewriter.load", QtWarningMsg)
static Q_LOGGING_CATEGORY(texttomodelMergerDebug, "qtc.texttomodelmerger.debug", QtDebugMsg)
namespace { namespace {
@@ -574,7 +575,7 @@ public:
if (parentObject) if (parentObject)
*parentObject = objectValue; *parentObject = objectValue;
if (!value) { if (!value) {
qWarning() << Q_FUNC_INFO << "Skipping invalid property name" << propertyName; qCInfo(texttomodelMergerDebug) << Q_FUNC_INFO << "Skipping invalid property name" << propertyName;
return false; return false;
} }
@@ -655,7 +656,8 @@ public:
const ObjectValue *containingObject = nullptr; const ObjectValue *containingObject = nullptr;
QString name; QString name;
if (!lookupProperty(propertyPrefix, propertyId, &property, &containingObject, &name)) { if (!lookupProperty(propertyPrefix, propertyId, &property, &containingObject, &name)) {
qWarning() << Q_FUNC_INFO << "Unknown property" << propertyPrefix + QLatin1Char('.') + toString(propertyId) qCInfo(texttomodelMergerDebug) << Q_FUNC_INFO << "Unknown property"
<< propertyPrefix + QLatin1Char('.') + toString(propertyId)
<< "on line" << propertyId->identifierToken.startLine << "on line" << propertyId->identifierToken.startLine
<< "column" << propertyId->identifierToken.startColumn; << "column" << propertyId->identifierToken.startColumn;
return hasQuotes ? QVariant(cleanedValue) : cleverConvert(cleanedValue); return hasQuotes ? QVariant(cleanedValue) : cleverConvert(cleanedValue);