feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Python: reduce freezes in settings page with remote interpreter

Browse Source 
Do not check the existence of remote interpreters when opening the
settingspage since we could run into device timeouts for unreachable
devices.

Change-Id: I5d0d1316961fc4ecbd2be55f6df70091ff65ecd5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
David Schulz
2023-10-18 07:25:23 +02:00
parent 499a786053
commit 18c00cd381
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/python/pythonsettings.cpp
View File

@@ -170,6 +170,8 @@ InterpreterOptionsWidget::InterpreterOptionsWidget()
return f; return f;
} }
case Qt::ToolTipRole: case Qt::ToolTipRole:
if (interpreter.command.needsDevice())
break;
if (interpreter.command.isEmpty()) if (interpreter.command.isEmpty())
return Tr::tr("Executable is empty."); return Tr::tr("Executable is empty.");
if (!interpreter.command.exists()) if (!interpreter.command.exists())
@@ -179,6 +181,8 @@ InterpreterOptionsWidget::InterpreterOptionsWidget()
.arg(interpreter.command.toUserOutput()); .arg(interpreter.command.toUserOutput());
break; break;
case Qt::DecorationRole: case Qt::DecorationRole:
if (interpreter.command.needsDevice())
break;
if (column == 0 && !interpreter.command.isExecutableFile()) if (column == 0 && !interpreter.command.isExecutableFile())
return Utils::Icons::CRITICAL.icon(); return Utils::Icons::CRITICAL.icon();
break; break;