AnalyzerTool: Make runMode and toolMode value members

Change-Id: Iaf89bc399db65e17345effb2e9767692786b5ca8
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
This commit is contained in:
hjk
2014-07-23 01:00:51 +02:00
parent 17ce7d4ad5
commit 18dca1e3ac
8 changed files with 36 additions and 42 deletions

View File

@@ -498,6 +498,8 @@ CallgrindTool::CallgrindTool(QObject *parent)
{
d = new CallgrindToolPrivate(this);
setObjectName(QLatin1String("CallgrindTool"));
setRunMode(CallgrindRunMode);
setToolMode(ReleaseMode);
connect(EditorManager::instance(), SIGNAL(editorOpened(Core::IEditor*)),
d, SLOT(editorOpened(Core::IEditor*)));
@@ -508,16 +510,6 @@ CallgrindTool::~CallgrindTool()
delete d;
}
RunMode CallgrindTool::runMode() const
{
return CallgrindRunMode;
}
IAnalyzerTool::ToolMode CallgrindTool::toolMode() const
{
return ReleaseMode;
}
AnalyzerRunControl *CallgrindTool::createRunControl(const AnalyzerStartParameters &sp,
RunConfiguration *runConfiguration)
{

View File

@@ -45,9 +45,6 @@ public:
CallgrindTool(QObject *parent);
~CallgrindTool();
ProjectExplorer::RunMode runMode() const;
ToolMode toolMode() const;
Analyzer::AnalyzerRunControl *createRunControl(const Analyzer::AnalyzerStartParameters &sp,
ProjectExplorer::RunConfiguration *runConfiguration = 0);
QWidget *createWidgets();

View File

@@ -193,7 +193,10 @@ MemcheckTool::MemcheckTool(QObject *parent)
m_errorProxyModel = 0;
m_errorView = 0;
m_filterMenu = 0;
setObjectName(QLatin1String("MemcheckTool"));
setRunMode(MemcheckRunMode);
setToolMode(DebugMode);
m_filterProjectAction = new QAction(tr("External Errors"), this);
m_filterProjectAction->setToolTip(
@@ -284,16 +287,6 @@ void MemcheckTool::maybeActiveRunConfigurationChanged()
updateFromSettings();
}
RunMode MemcheckTool::runMode() const
{
return MemcheckRunMode;
}
IAnalyzerTool::ToolMode MemcheckTool::toolMode() const
{
return DebugMode;
}
class FrameFinder : public ErrorListModel::RelevantFrameFinder
{
public:

View File

@@ -81,8 +81,6 @@ class MemcheckTool : public ValgrindTool
public:
MemcheckTool(QObject *parent);
ProjectExplorer::RunMode runMode() const;
private slots:
void settingsDestroyed(QObject *settings);
void maybeActiveRunConfigurationChanged();
@@ -99,7 +97,6 @@ private slots:
void loadExternalXmlLogFile();
private:
ToolMode toolMode() const;
QWidget *createWidgets();
void setBusyCursor(bool busy);