feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VcsCommand: Remove one addJob overload

Browse Source 
Remove defaultTimeoutS field, as it wasn't broadly used.

Change-Id: I0056788b066eb6d682d5ba7acdb01d5dd3568967
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2022-08-03 07:27:51 +02:00
parent d2a1198a7b
commit 191fc196d5
5 changed files with 4 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/vcsbase/vcsbaseclient.cpp
View File

@@ -96,7 +96,6 @@ VcsCommand *VcsBaseClientImpl::createCommand(const FilePath &workingDirectory,
JobOutputBindMode mode) const
{
auto cmd = createVcsCommand(workingDirectory, processEnvironment());
cmd->setDefaultTimeoutS(vcsTimeoutS());
if (editor)
editor->setCommand(cmd);
if (mode == VcsWindowOutputBind) {
@@ -119,7 +118,7 @@ VcsCommand *VcsBaseClientImpl::execBgCommand(const FilePath &workingDirectory,
cmd->addFlags(flags | VcsCommand::SuppressCommandLogging
| VcsCommand::SuppressStdErr
| VcsCommand::SuppressFailMessage);
cmd->addJob({vcsBinary(), args});
cmd->addJob({vcsBinary(), args}, vcsTimeoutS());
connect(cmd, &VcsCommand::stdOutText, this, outputCallback);
cmd->execute();
return cmd;