feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Introduce TreeItem::{begin,end}

Browse Source 
... and use this to reduce the number of explicit uses of m_children.

Despite of being shorter code by itself it is a step towards having
an explicit LeafItem object that doesn't explicitly store a(n empty)
vector of child nodes.

Change-Id: If8db85e2f1134dd1578a78d31235bf57a28f863a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
hjk
2017-02-07 08:53:00 +01:00
parent af54ab960a
commit 196dbbe0e7
16 changed files with 75 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/projectexplorer/projectwindow.cpp
View File

@@ -178,7 +178,7 @@ public:
if (role == ItemActivatedFromBelowRole) {
TreeItem *item = data.value<TreeItem *>();
QTC_ASSERT(item, return false);
m_currentPanelIndex = children().indexOf(item);
m_currentPanelIndex = indexOf(item);
QTC_ASSERT(m_currentPanelIndex != -1, return false);
parent()->setData(0, QVariant::fromValue(static_cast<TreeItem *>(this)),
ItemActivatedFromBelowRole);
@@ -251,9 +251,9 @@ public:
}
if (role == ItemActivatedFromBelowRole) {
TreeItem *item = dat.value<TreeItem *>();
const TreeItem *item = dat.value<TreeItem *>();
QTC_ASSERT(item, return false);
int res = children().indexOf(item);
int res = indexOf(item);
QTC_ASSERT(res >= 0, return false);
m_currentChildIndex = res;
announceChange();