feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Add const reverse iterators to SmallString

Browse Source 
Change-Id: Iefd9d6abafbe38dcb7d3ed9ea200ac3244902433
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Marco Bubke
2016-11-16 15:53:03 +01:00
parent 8a16151601
commit 19a00f418f
2 changed files with 33 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/libs/utils/smallstring.h
View File

@@ -299,6 +299,16 @@ public:
return reverse_iterator(begin() - static_cast<std::size_t>(1)); return reverse_iterator(begin() - static_cast<std::size_t>(1));
} }
const_reverse_iterator rbegin() const noexcept
{
return const_reverse_iterator(end() - static_cast<std::size_t>(1));
}
const_reverse_iterator rend() const noexcept
{
return const_reverse_iterator(begin() - static_cast<std::size_t>(1));
}
const_iterator begin() const noexcept const_iterator begin() const noexcept
{ {
return constData(); return constData();

23
tests/unit/unittest/smallstring-test.cpp
View File

@@ -317,6 +317,29 @@ TEST(SmallString, RBeginPlusOneIsEqualREndForSmallStringWidthSizeOne)
ASSERT_THAT(beginPlusOne, Eq(text.rend())); ASSERT_THAT(beginPlusOne, Eq(text.rend()));
} }
TEST(SmallString, ConstRBeginIsEqualREndForEmptySmallString)
{
const SmallString text;
ASSERT_THAT(text.rbegin(), Eq(text.rend()));
}
TEST(SmallString, ConstRBeginIsNotEqualREndForNonEmptySmallString)
{
const SmallString text("x");
ASSERT_THAT(text.rbegin(), Ne(text.rend()));
}
TEST(SmallString, ConstRBeginPlusOneIsEqualREndForSmallStringWidthSizeOne)
{
const SmallString text("x");
auto beginPlusOne = text.rbegin() + 1l;
ASSERT_THAT(beginPlusOne, Eq(text.rend()));
}
TEST(SmallString, ConstructorStandardString) TEST(SmallString, ConstructorStandardString)
{ {
std::string stdStringText = "short string"; std::string stdStringText = "short string";