From 19a47fed29969484313d76c125915dedf19cb6e6 Mon Sep 17 00:00:00 2001
From: hjk <hjk@qt.io>
Date: Tue, 23 May 2017 13:12:07 +0200
Subject: [PATCH] ProjectExplorer: Remove various RunControl::report* functions

The interface has now moved to the RunWorkers.

Change-Id: I1ebf74c081697b8e44926ab00053417f9f60647d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
---
 src/plugins/projectexplorer/runconfiguration.cpp | 16 ----------------
 src/plugins/projectexplorer/runconfiguration.h   |  8 ++------
 2 files changed, 2 insertions(+), 22 deletions(-)

diff --git a/src/plugins/projectexplorer/runconfiguration.cpp b/src/plugins/projectexplorer/runconfiguration.cpp
index 5e357f8d6ef..0260081166f 100644
--- a/src/plugins/projectexplorer/runconfiguration.cpp
+++ b/src/plugins/projectexplorer/runconfiguration.cpp
@@ -1150,16 +1150,6 @@ void RunControl::bringApplicationToForeground()
 #endif
 }
 
-void RunControl::reportApplicationStart()
-{
-    QTC_CHECK(false);//  FIXME: Legacy
-}
-
-void RunControl::reportApplicationStop()
-{
-    QTC_CHECK(false);//  FIXME: Legacy
-}
-
 void RunControl::bringApplicationToForegroundInternal()
 {
 #ifdef Q_OS_OSX
@@ -1315,12 +1305,6 @@ void SimpleTargetRunner::onProcessError(QProcess::ProcessError)
     reportStopped();
 }
 
-void RunControl::reportFailure(const QString &msg)
-{
-    d->showError(msg);
-    d->setState(RunControlState::Stopped);
-}
-
 // RunWorkerPrivate
 
 RunWorkerPrivate::RunWorkerPrivate(RunWorker *runWorker, RunControl *runControl)
diff --git a/src/plugins/projectexplorer/runconfiguration.h b/src/plugins/projectexplorer/runconfiguration.h
index 3f25e8fc1fe..f69e42f513c 100644
--- a/src/plugins/projectexplorer/runconfiguration.h
+++ b/src/plugins/projectexplorer/runconfiguration.h
@@ -469,10 +469,6 @@ public:
     virtual void notifyRemoteSetupFailed(const QString &) {} // Same.
     virtual void notifyRemoteFinished() {} // Same.
 
-    void reportApplicationStart(); // FIXME: Don't use
-    void reportApplicationStop(); // FIXME: Don't use
-    void reportFailure(const QString &msg = QString());
-
     static bool showPromptToStopDialog(const QString &title, const QString &text,
                                        const QString &stopButtonText = QString(),
                                        const QString &cancelButtonText = QString(),
@@ -505,8 +501,8 @@ signals:
                                 const QString &msg, Utils::OutputFormat format);
     void aboutToStart();
     void starting();
-    void started(); // Use reportApplicationStart!
-    void finished(); // Use reportApplicationStop!
+    void started();
+    void finished();
     void applicationProcessHandleChanged(QPrivateSignal); // Use setApplicationProcessHandle
 
 private: