feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ValgrindRunner: Inline some slots

Browse Source 
Change-Id: I29b099694fd0cbbd29bbd34362f2d93074b125d1
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2023-08-16 14:11:40 +02:00
parent 89343f6574
commit 19bc9e69c9
1 changed files with 15 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
src/plugins/valgrind/valgrindrunner.cpp
View File

@@ -41,8 +41,21 @@ public:
emit q->appendMessage(m_process.readAllStandardError(), StdErrFormat); emit q->appendMessage(m_process.readAllStandardError(), StdErrFormat);
}); });
connect(&m_xmlServer, &QTcpServer::newConnection, this, &Private::xmlSocketConnected); connect(&m_xmlServer, &QTcpServer::newConnection, this, [this] {
connect(&m_logServer, &QTcpServer::newConnection, this, &Private::logSocketConnected); QTcpSocket *socket = m_xmlServer.nextPendingConnection();
QTC_ASSERT(socket, return);
m_xmlServer.close();
m_parser.setSocket(socket);
m_parser.start();
});
connect(&m_logServer, &QTcpServer::newConnection, this, [this] {
QTcpSocket *socket = m_logServer.nextPendingConnection();
QTC_ASSERT(socket, return);
connect(socket, &QIODevice::readyRead, this, [this, socket] {
emit q->logMessageReceived(socket->readAll());
});
m_logServer.close();
});
connect(&m_parser, &Parser::status, q, &ValgrindRunner::status); connect(&m_parser, &Parser::status, q, &ValgrindRunner::status);
connect(&m_parser, &Parser::error, q, &ValgrindRunner::error); connect(&m_parser, &Parser::error, q, &ValgrindRunner::error);
@@ -52,8 +65,6 @@ public:
}); });
} }
void xmlSocketConnected();
void logSocketConnected();
bool startServers(); bool startServers();
bool run(); bool run();
@@ -71,25 +82,6 @@ public:
Parser m_parser; Parser m_parser;
}; };
void ValgrindRunner::Private::xmlSocketConnected()
{
QTcpSocket *socket = m_xmlServer.nextPendingConnection();
QTC_ASSERT(socket, return);
m_xmlServer.close();
m_parser.setSocket(socket);
m_parser.start();
}
void ValgrindRunner::Private::logSocketConnected()
{
QTcpSocket *logSocket = m_logServer.nextPendingConnection();
QTC_ASSERT(logSocket, return);
connect(logSocket, &QIODevice::readyRead, this, [this, logSocket] {
emit q->logMessageReceived(logSocket->readAll());
});
m_logServer.close();
}
bool ValgrindRunner::Private::startServers() bool ValgrindRunner::Private::startServers()
{ {
const bool xmlOK = m_xmlServer.listen(m_localServerAddress); const bool xmlOK = m_xmlServer.listen(m_localServerAddress);