feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AutoTest: Avoid passing around pointer without owner...

Browse Source 
...when using signals and slots between threads.

Change-Id: Ib1ce607e225cb8d9973393c5bdaeebaa6e30bb41
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
This commit is contained in:
Christian Stenger
2016-02-25 13:02:31 +01:00
parent ba61f2946d
commit 19c8c9bc4b
9 changed files with 62 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/autotest/testresultmodel.cpp
View File

@@ -33,14 +33,13 @@ namespace Internal {
/********************************* TestResultItem ******************************************/
TestResultItem::TestResultItem(TestResult *testResult)
TestResultItem::TestResultItem(const TestResultPtr &testResult)
: m_testResult(testResult)
{
}
TestResultItem::~TestResultItem()
{
delete m_testResult;
}
static QIcon testResultIcon(Result::Type result) {
@@ -138,7 +137,7 @@ QVariant TestResultModel::data(const QModelIndex &idx, int role) const
return QVariant();
}
void TestResultModel::addTestResult(TestResult *testResult, bool autoExpand)
void TestResultModel::addTestResult(const TestResultPtr &testResult, bool autoExpand)
{
const bool isCurrentTestMssg = testResult->result() == Result::MessageCurrentTest;
@@ -158,7 +157,6 @@ void TestResultModel::addTestResult(TestResult *testResult, bool autoExpand)
if (result && result->result() == Result::MessageCurrentTest) {
current->updateDescription(testResult->description());
emit dataChanged(current->index(), current->index());
delete testResult;
return;
}
}