feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Get rid of FancyLineEdit::validate

Browse Source 
Use aggregation instead of inheritance for customization of validation

Change-Id: I5a9703bad5bace78e8c3cc1e2c353a734001bd0a
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
This commit is contained in:
Eike Ziller
2015-04-28 14:50:47 +02:00
parent dca023a855
commit 1a122c2e25
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
plugins/clangstaticanalyzer/clangstaticanalyzerconfigwidget.cpp
View File

@@ -40,10 +40,11 @@ ClangStaticAnalyzerConfigWidget::ClangStaticAnalyzerConfigWidget(
chooser->setHistoryCompleter(QLatin1String("ClangStaticAnalyzer.ClangCommand.History")); chooser->setHistoryCompleter(QLatin1String("ClangStaticAnalyzer.ClangCommand.History"));
chooser->setPromptDialogTitle(tr("Clang Command")); chooser->setPromptDialogTitle(tr("Clang Command"));
chooser->setPath(settings->clangExecutable()); chooser->setPath(settings->clangExecutable());
const auto validator = [chooser](const QString &, QString *errorMessage) { const auto validator = [chooser](Utils::FancyLineEdit *edit, QString *errorMessage) {
return isClangExecutableUsable(chooser->fileName().toString(), errorMessage); return chooser->defaultValidationFunction()(edit, errorMessage)
&& isClangExecutableUsable(chooser->fileName().toString(), errorMessage);
}; };
chooser->setAdditionalPathValidator(validator); chooser->setValidationFunction(validator);
connect(m_ui->clangExecutableChooser, &Utils::PathChooser::changed, connect(m_ui->clangExecutableChooser, &Utils::PathChooser::changed,
[settings](const QString &path) { settings->setClangExecutable(path); }); [settings](const QString &path) { settings->setClangExecutable(path); });