From 1b0279955fa251cb5d541509bf6a26616433eadd Mon Sep 17 00:00:00 2001 From: Daniel Teske Date: Wed, 16 Jul 2014 15:37:55 +0200 Subject: [PATCH] AndroidManifestEditor: Fix versionCode being limited The android documentation does not require a minimum value of 1, but suggest that "Typically, you would release the first version of your application with versionCode set to 1". Thus keep the minimum of 1. A maximum value is not specified. Task-number: QTCREATORBUG-12668 Change-Id: I6bfb0a534661af82b6fcfe5667d9224893707e41 Reviewed-by: Eskil Abrahamsen Blomfeldt --- src/plugins/android/androidmanifesteditorwidget.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/plugins/android/androidmanifesteditorwidget.cpp b/src/plugins/android/androidmanifesteditorwidget.cpp index fa47a0b9eb9..04be02cae21 100644 --- a/src/plugins/android/androidmanifesteditorwidget.cpp +++ b/src/plugins/android/androidmanifesteditorwidget.cpp @@ -70,6 +70,8 @@ #include #include +#include + using namespace ProjectExplorer; using namespace Android; using namespace Android::Internal; @@ -180,7 +182,7 @@ void AndroidManifestEditorWidget::initializePage() m_versionCode = new QSpinBox(packageGroupBox); - m_versionCode->setMaximum(99); + m_versionCode->setMaximum(std::numeric_limits::max()); m_versionCode->setValue(1); m_versionCode->setSizePolicy(QSizePolicy::Fixed, QSizePolicy::Fixed); formLayout->addRow(tr("Version code:"), m_versionCode);