From 1b53c931c5bd544811cbdb51441c76b17c482b2a Mon Sep 17 00:00:00 2001
From: Semih Yavuz <semih.yavuz@qt.io>
Date: Fri, 23 Feb 2024 11:44:17 +0100
Subject: [PATCH] qmllssettings: Fix incorrect detecting of latest version

Update the latestVersion in the loop. Otherwise we always compare to
initial value and consequently the last installed version incorrecyly
becomes the latest version.

Fixes: QTCREATORBUG-30423
Change-Id: I7083928c5e371f0337677eacf1b3b4da50358a7c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
---
 src/plugins/qmljseditor/qmllssettings.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/plugins/qmljseditor/qmllssettings.cpp b/src/plugins/qmljseditor/qmllssettings.cpp
index 76ce535fa79..15cb8908afb 100644
--- a/src/plugins/qmljseditor/qmllssettings.cpp
+++ b/src/plugins/qmljseditor/qmllssettings.cpp
@@ -49,6 +49,7 @@ static FilePath evaluateLatestQmlls()
             if (latestQmakeFilePath == qmakeNow && latestUniqueId >= v->uniqueId())
                 continue;
         }
+        latestVersion = vNow;
         latestQmlls = qmllsNow;
         latestQmakeFilePath = qmakeNow;
         latestUniqueId = uniqueIdNow;