feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Copilot: Do not try to start copilot without nodejs

Browse Source 
Avoids the attempt to start the client if nodejs cannot be
found.

Change-Id: I3783280120ca754291a92b3308c1192906facd08
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This commit is contained in:
Christian Stenger
2023-05-31 12:15:48 +02:00
parent 58fb6f88a6
commit 1bc3cccbb4
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/copilot/authwidget.cpp
View File

@@ -93,7 +93,7 @@ void AuthWidget::updateClient(const Utils::FilePath &nodeJs, const Utils::FilePa
m_client = nullptr; m_client = nullptr;
setState(Tr::tr("Sign in"), false); setState(Tr::tr("Sign in"), false);
m_button->setEnabled(false); m_button->setEnabled(false);
if (!nodeJs.exists() || !agent.exists()) { if (!nodeJs.isExecutableFile() || !agent.exists()) {
return; return;
} }

3
src/plugins/copilot/copilotplugin.cpp
View File

@@ -120,6 +120,9 @@ void CopilotPlugin::extensionsInitialized()
void CopilotPlugin::restartClient() void CopilotPlugin::restartClient()
{ {
LanguageClient::LanguageClientManager::shutdownClient(m_client); LanguageClient::LanguageClientManager::shutdownClient(m_client);
if (!CopilotSettings::instance().nodeJsPath().isExecutableFile())
return;
m_client = new CopilotClient(CopilotSettings::instance().nodeJsPath(), m_client = new CopilotClient(CopilotSettings::instance().nodeJsPath(),
CopilotSettings::instance().distPath()); CopilotSettings::instance().distPath());
} }