feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Do not use QDir::separator() for internal paths

Browse Source 
Internal paths are supposed to be normalized

Change-Id: Ic6943ce13ad389dfdb44054a9e6f03da8c6cd88d
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
This commit is contained in:
Orgad Shaneh
2015-01-31 22:11:11 +02:00
committed by Orgad Shaneh
parent 704f3d539b
commit 1bcfa137a3
12 changed files with 23 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/perforce/perforceplugin.cpp
View File

@@ -962,8 +962,9 @@ PerforcePlugin::createTemporaryArgumentFile(const QStringList &extraArgs,
QString pattern = m_instance->m_tempFilePattern;
if (pattern.isEmpty()) {
pattern = QDir::tempPath();
if (!pattern.endsWith(QDir::separator()))
pattern += QDir::separator();
const QChar slash = QLatin1Char('/');
if (!pattern.endsWith(slash))
pattern += slash;
pattern += QLatin1String("qtc_p4_XXXXXX.args");
m_instance->m_tempFilePattern = pattern;
}