feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Axivion: Tweak issue click behavior

Browse Source 
Request the issue properties on selection and try to open
the file on double click.

Change-Id: I264e0fb4827183540e80f5544a4d77ce29ab088b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
Christian Stenger
2025-01-13 13:42:15 +01:00
parent 7985dea963
commit 1be28e49b0
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/axivion/axivionperspective.cpp
View File

@@ -66,6 +66,8 @@ using namespace Utils;
namespace Axivion::Internal { namespace Axivion::Internal {
constexpr int ListItemIdRole = Qt::UserRole + 2;
static const Icon MARKER_ICON({{":/axivion/images/marker.png", Theme::IconsBaseColor}}); static const Icon MARKER_ICON({{":/axivion/images/marker.png", Theme::IconsBaseColor}});
static const Icon USER_ICON({{":/axivion/images/user.png", Theme::PanelTextColorDark}}, Icon::Tint); static const Icon USER_ICON({{":/axivion/images/user.png", Theme::PanelTextColorDark}}, Icon::Tint);
@@ -130,6 +132,8 @@ public:
return m_data.at(column); return m_data.at(column);
if (role == Qt::ToolTipRole && column >= 0 && column < m_toolTips.size()) if (role == Qt::ToolTipRole && column >= 0 && column < m_toolTips.size())
return m_toolTips.at(column); return m_toolTips.at(column);
if (role == ListItemIdRole)
return m_id;
return {}; return {};
} }
@@ -162,8 +166,6 @@ public:
if (link.targetFilePath.exists()) if (link.targetFilePath.exists())
EditorManager::openEditorAt(link); EditorManager::openEditorAt(link);
} }
if (!m_id.isEmpty())
fetchIssueInfo(m_id);
return true; return true;
} else if (role == BaseTreeView::ItemViewEventRole && !m_id.isEmpty()) { } else if (role == BaseTreeView::ItemViewEventRole && !m_id.isEmpty()) {
ItemViewEvent ev = value.value<ItemViewEvent>(); ItemViewEvent ev = value.value<ItemViewEvent>();
@@ -372,6 +374,14 @@ IssuesWidget::IssuesWidget(QWidget *parent)
m_issuesModel = new DynamicListModel(this); m_issuesModel = new DynamicListModel(this);
m_issuesView->setModel(m_issuesModel); m_issuesView->setModel(m_issuesModel);
connect(m_issuesModel, &DynamicListModel::fetchRequested, this, &IssuesWidget::onFetchRequested); connect(m_issuesModel, &DynamicListModel::fetchRequested, this, &IssuesWidget::onFetchRequested);
connect(m_issuesView->selectionModel(), &QItemSelectionModel::selectionChanged,
this, [this](const QItemSelection &selected, const QItemSelection &) {
if (selected.isEmpty())
return;
const QString id = m_issuesModel->data(m_issuesView->currentIndex(), ListItemIdRole).toString();
QTC_ASSERT(!id.isEmpty(), return);
fetchIssueInfo(id);
});
m_totalRows = new QLabel(Tr::tr("Total rows:"), this); m_totalRows = new QLabel(Tr::tr("Total rows:"), this);
QWidget *errorWidget = new QWidget(this); QWidget *errorWidget = new QWidget(this);