feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Pass some values by reference

Browse Source 
Change-Id: I628c317fc86f1f4b33ca453018d54fb86babc1e8
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
This commit is contained in:
Orgad Shaneh
2014-05-19 18:34:53 +03:00
committed by Orgad Shaneh
parent b9fedaa42b
commit 1c47b15d18
7 changed files with 13 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/projectexplorer/compileoutputwindow.cpp
View File

@@ -176,7 +176,7 @@ QList<QWidget *> CompileOutputWindow::toolBarWidgets() const
return QList<QWidget *>() << m_cancelBuildButton;
}
static QColor mix_colors(QColor a, QColor b)
static QColor mix_colors(const QColor &a, const QColor &b)
{
return QColor((a.red() + 2 * b.red()) / 3, (a.green() + 2 * b.green()) / 3,
(a.blue() + 2* b.blue()) / 3, (a.alpha() + 2 * b.alpha()) / 3);

2
src/plugins/projectexplorer/devicesupport/devicemanagermodel.cpp
View File

@@ -62,7 +62,7 @@ DeviceManagerModel::~DeviceManagerModel()
delete d;
}
void DeviceManagerModel::setFilter(const QList<Core::Id> filter)
void DeviceManagerModel::setFilter(const QList<Core::Id> &filter)
{
d->filter = filter;
handleDeviceListChanged();

2
src/plugins/projectexplorer/devicesupport/devicemanagermodel.h
View File

@@ -46,7 +46,7 @@ public:
explicit DeviceManagerModel(const DeviceManager *deviceManager, QObject *parent = 0);
~DeviceManagerModel();
void setFilter(const QList<Core::Id> filter);
void setFilter(const QList<Core::Id> &filter);
void setTypeFilter(const Core::Id &type);
IDevice::ConstPtr device(int pos) const;

4
src/plugins/projectexplorer/outputparser_test.cpp
View File

@@ -89,8 +89,8 @@ void OutputParserTester::testParsing(const QString &lines,
}
}
void OutputParserTester::testTaskMangling(const Task input,
const Task output)
void OutputParserTester::testTaskMangling(const Task &input,
const Task &output)
{
reset();
childParser()->taskAdded(input);

4
src/plugins/projectexplorer/outputparser_test.h
View File

@@ -60,8 +60,8 @@ public:
const QString &childStdOutLines,
const QString &childStdErrLines,
const QString &outputLines);
void testTaskMangling(const Task input,
const Task output);
void testTaskMangling(const Task &input,
const Task &output);
void testOutputMangling(const QString &input,
const QString &output);

6
src/plugins/projectexplorer/selectablefilesmodel.cpp
View File

@@ -529,7 +529,9 @@ Qt::CheckState SelectableFilesModel::applyFilter(const QModelIndex &index)
// SelectableFilesDialogs
//////////
SelectableFilesDialogEditFiles::SelectableFilesDialogEditFiles(const QString &path, const QStringList files, QWidget *parent)
SelectableFilesDialogEditFiles::SelectableFilesDialogEditFiles(const QString &path,
const QStringList &files,
QWidget *parent)
: QDialog(parent)
{
QVBoxLayout *layout = new QVBoxLayout();
@@ -683,7 +685,7 @@ void SelectableFilesDialogEditFiles::applyFilter()
}
SelectableFilesDialogAddDirectory::SelectableFilesDialogAddDirectory(const QString &path,
const QStringList files, QWidget *parent) :
const QStringList &files, QWidget *parent) :
SelectableFilesDialogEditFiles(path, files, parent)
{
setWindowTitle(tr("Add Existing Directory"));

4
src/plugins/projectexplorer/selectablefilesmodel.h
View File

@@ -150,7 +150,7 @@ class PROJECTEXPLORER_EXPORT SelectableFilesDialogEditFiles : public QDialog
Q_OBJECT
public:
SelectableFilesDialogEditFiles(const QString &path, const QStringList files, QWidget *parent);
SelectableFilesDialogEditFiles(const QString &path, const QStringList &files, QWidget *parent);
~SelectableFilesDialogEditFiles();
QStringList selectedFiles() const;
@@ -185,7 +185,7 @@ class SelectableFilesDialogAddDirectory : public SelectableFilesDialogEditFiles
Q_OBJECT
public:
SelectableFilesDialogAddDirectory(const QString &path, const QStringList files, QWidget *parent);
SelectableFilesDialogAddDirectory(const QString &path, const QStringList &files, QWidget *parent);
private slots:
void validityOfDirectoryChanged(bool validState);