feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Replace the fromMap error return value

Browse Source 
... by some out-of-band mechanism, keeping previous functionality.

The driving reason is to get the same fromMap signature as in the
AspectContainer base, however, the whole mechanism seems rather useless:
There are only a few places that actually ever could report errors,
in those places "moving on" looks ok, too, and these few places
are not conceptually different than a lot others.

Removal of this (new) mechanism is left for later.

Change-Id: Ibe7a0456bc3b84a84e942231f14446e783372d76
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
hjk
2023-07-21 18:23:50 +02:00
parent a263d3de89
commit 1c4f973365
39 changed files with 100 additions and 118 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/ios/iosdsymbuildstep.cpp
View File

@@ -60,7 +60,7 @@ public:
private:
void setupOutputFormatter(OutputFormatter *formatter) override;
void toMap(QVariantMap &map) const override;
bool fromMap(const QVariantMap &map) override;
void fromMap(const QVariantMap &map) override;
QStringList defaultCleanCmdList() const;
QStringList defaultCmdList() const;
@@ -95,7 +95,7 @@ void IosDsymBuildStep::toMap(QVariantMap &map) const
map.insert(id().withSuffix(COMMAND_PARTIAL_KEY).toString(), command().toSettings());
}
bool IosDsymBuildStep::fromMap(const QVariantMap &map)
void IosDsymBuildStep::fromMap(const QVariantMap &map)
{
QVariant bArgs = map.value(id().withSuffix(ARGUMENTS_PARTIAL_KEY).toString());
m_arguments = bArgs.toStringList();
@@ -108,7 +108,7 @@ bool IosDsymBuildStep::fromMap(const QVariantMap &map)
m_arguments = defaultArguments();
}
return BuildStep::fromMap(map);
BuildStep::fromMap(map);
}
QStringList IosDsymBuildStep::defaultArguments() const