feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Replace the fromMap error return value

Browse Source 
... by some out-of-band mechanism, keeping previous functionality.

The driving reason is to get the same fromMap signature as in the
AspectContainer base, however, the whole mechanism seems rather useless:
There are only a few places that actually ever could report errors,
in those places "moving on" looks ok, too, and these few places
are not conceptually different than a lot others.

Removal of this (new) mechanism is left for later.

Change-Id: Ibe7a0456bc3b84a84e942231f14446e783372d76
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
hjk
2023-07-21 18:23:50 +02:00
parent a263d3de89
commit 1c4f973365
39 changed files with 100 additions and 118 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/mesonprojectmanager/ninjabuildstep.cpp
View File

@@ -206,7 +206,7 @@ void NinjaBuildStep::toMap(QVariantMap &map) const
map.insert(TOOL_ARGUMENTS_KEY, m_commandArgs);
}
bool NinjaBuildStep::fromMap(const QVariantMap &map)
void NinjaBuildStep::fromMap(const QVariantMap &map)
{
m_targetName = map.value(TARGETS_KEY).toString();
m_commandArgs = map.value(TOOL_ARGUMENTS_KEY).toString();