feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Squish: Avoid using keys()

Browse Source 
Instead, iterate directly over the container.

Change-Id: I3fd55988fd3351f738e07c3b0611872279d929b4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Jarek Kobus
2024-01-09 00:31:33 +01:00
parent d358589004
commit 1c8e88651c
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/squish/squishfilehandler.cpp
View File

@@ -83,8 +83,8 @@ public:
SquishServerSettings s; SquishServerSettings s;
s.setFromXmlOutput(out); s.setFromXmlOutput(out);
QApplication::restoreOverrideCursor(); QApplication::restoreOverrideCursor();
for (const QString &app : s.mappedAuts.keys()) for (auto it = s.mappedAuts.cbegin(); it != s.mappedAuts.cend(); ++it)
aut.addItem(app); aut.addItem(it.key());
}); });
} }
@@ -358,10 +358,9 @@ void SquishFileHandler::closeAllInternal()
// TODO remove file watcher // TODO remove file watcher
for (auto suiteConfFilePath : m_suites) for (auto suiteConfFilePath : m_suites)
closeOpenedEditorsFor(suiteConfFilePath.parentDir(), true); closeOpenedEditorsFor(suiteConfFilePath.parentDir(), true);
const QStringList &suiteNames = m_suites.keys();
m_suites.clear(); m_suites.clear();
for (const QString &suiteName : suiteNames) for (auto it = m_suites.cbegin(); it != m_suites.cend(); ++it)
emit suiteTreeItemRemoved(suiteName); emit suiteTreeItemRemoved(it.key());
} }
void SquishFileHandler::runTestCase(const QString &suiteName, const QString &testCaseName) void SquishFileHandler::runTestCase(const QString &suiteName, const QString &testCaseName)