From 1ce7adce470d9c2eae3fa119ac65c935dc2de5b9 Mon Sep 17 00:00:00 2001 From: hjk Date: Mon, 7 Jun 2021 11:34:35 +0200 Subject: [PATCH] Utils: Set the working directory in QtcProcess::start The m_process member is strictly speaking only needed for processes handled "fully locally", i.e. without diversion through any device. Better set it only when needed, even if only to avoid even unused locally illegal paths like "docker://123/tmp/x" as working directory. Change-Id: Ia9e686855ff0c213eb3be03def8c4cecc7ee37ae Reviewed-by: Christian Stenger --- src/libs/utils/qtcprocess.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/utils/qtcprocess.cpp b/src/libs/utils/qtcprocess.cpp index 71a3f74180b..be287e276ef 100644 --- a/src/libs/utils/qtcprocess.cpp +++ b/src/libs/utils/qtcprocess.cpp @@ -288,7 +288,6 @@ void QtcProcess::setWorkingDirectory(const FilePath &dir) QTC_CHECK(dir.host() == d->m_commandLine.executable().host()); } d->m_workingDirectory = dir; - d->m_process->setWorkingDirectory(dir.toString()); } void QtcProcess::setWorkingDirectory(const QString &dir) @@ -338,6 +337,7 @@ void QtcProcess::start() } const QString workDir = d->m_workingDirectory.path(); + d->m_process->setWorkingDirectory(workDir); QString command; ProcessArgs arguments;