feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QtcProcess: Get rid of useTerminal

Browse Source 
Remove SshRemoteProcessRunner::runInTerminal() method,
it wasn't used anywhere (just in test).
Remove QtcProcess::useTerminal, as process should be
created in TerminalOn mode when there is a need for terminal.
Add a parameter to
SshRemoteProcess::fullLocalCommandLine(bool inTerminal)
as this may still be needed when running application
through ssh from terminal (ssh -tt option).

Change-Id: I71911082fcca190b82a1106a2ca1ca48dc5d4c79
Reviewed-by: hjk <hjk@qt.io>
(cherry picked from commit 95a9b22f6f)
This commit is contained in:
Jarek Kobus
2022-01-28 12:08:09 +01:00
parent 5c53dc5e13
commit 1d15a934cd
8 changed files with 8 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/libs/utils/qtcprocess.cpp
View File

@@ -260,9 +260,6 @@ public:
void setUnixTerminalDisabled() { m_unixTerminalDisabled = true; }
bool isUnixTerminalDisabled() const { return m_unixTerminalDisabled; }
void setUseTerminal(bool on) { m_useTerminal = on; }
bool useTerminal() const { return m_useTerminal; }
void setAbortOnMetaChars(bool abort) { m_abortOnMetaChars = abort; }
bool isAbortOnMetaChars() const { return m_abortOnMetaChars; }
@@ -289,7 +286,6 @@ private:
QString m_nativeArguments;
bool m_lowPriority = false;
bool m_unixTerminalDisabled = false;
bool m_useTerminal = false;
bool m_abortOnMetaChars = true;
bool m_runAsRoot = false;
};
@@ -908,16 +904,6 @@ void QtcProcess::setDisableUnixTerminal()
d->m_process->setUnixTerminalDisabled();
}
void QtcProcess::setUseTerminal(bool on)
{
d->m_process->setUseTerminal(on);
}
bool QtcProcess::useTerminal() const
{
return d->m_process->useTerminal();
}
void QtcProcess::setAbortOnMetaChars(bool abort)
{
d->m_process->setAbortOnMetaChars(abort);