feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QtcProcess: Get rid of useTerminal

Browse Source 
Remove SshRemoteProcessRunner::runInTerminal() method,
it wasn't used anywhere (just in test).
Remove QtcProcess::useTerminal, as process should be
created in TerminalOn mode when there is a need for terminal.
Add a parameter to
SshRemoteProcess::fullLocalCommandLine(bool inTerminal)
as this may still be needed when running application
through ssh from terminal (ssh -tt option).

Change-Id: I71911082fcca190b82a1106a2ca1ca48dc5d4c79
Reviewed-by: hjk <hjk@qt.io>
(cherry picked from commit 95a9b22f6f)
This commit is contained in:
Jarek Kobus
2022-01-28 12:08:09 +01:00
parent 5c53dc5e13
commit 1d15a934cd
8 changed files with 8 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/projectexplorer/devicesupport/sshdeviceprocess.cpp
View File

@@ -192,7 +192,6 @@ void SshDeviceProcess::handleConnected()
if (!display.isEmpty())
d->process->requestX11Forwarding(display);
if (runInTerminal()) {
d->process->setUseTerminal(true);
connect(&d->consoleProcess, &QtcProcess::errorOccurred,
this, &DeviceProcess::errorOccurred);
connect(&d->consoleProcess, &QtcProcess::started,
@@ -200,7 +199,7 @@ void SshDeviceProcess::handleConnected()
connect(&d->consoleProcess, &QtcProcess::finished,
this, [this] { handleProcessFinished(d->consoleProcess.errorString()); });
d->consoleProcess.setAbortOnMetaChars(false);
d->consoleProcess.setCommand(d->process->fullLocalCommandLine());
d->consoleProcess.setCommand(d->process->fullLocalCommandLine(true));
d->consoleProcess.start();
} else {
connect(d->process.get(), &QSsh::SshRemoteProcess::started,