feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Shift parts of KitManagerConfigWidget creation

Browse Source 
... from the kit manager to the actual KitManagerConfigWidget

Preliminary to more direct use of e.g. KitAspect::description()

Change-Id: I20fd027903938904b3725d25483eca26b5bb0262
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-02-11 16:42:49 +01:00
parent 7c4c07d22a
commit 1d23f8b93d
3 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/projectexplorer/kitmanager.cpp
View File

@@ -374,7 +374,7 @@ KitManagerConfigWidget *KitManager::createConfigWidget(Kit *k)
{ {
auto *result = new KitManagerConfigWidget(k); auto *result = new KitManagerConfigWidget(k);
foreach (KitAspect *ki, kitInformation()) foreach (KitAspect *ki, kitInformation())
result->addConfigWidget(ki->createConfigWidget(result->workingCopy())); result->addAspectToWorkingCopy(ki);
result->updateVisibility(); result->updateVisibility();

4
src/plugins/projectexplorer/kitmanagerconfigwidget.cpp
View File

@@ -211,8 +211,10 @@ QString KitManagerConfigWidget::validityMessage() const
return m_modifiedKit->toHtml(tmp); return m_modifiedKit->toHtml(tmp);
} }
void KitManagerConfigWidget::addConfigWidget(KitAspectWidget *widget) void KitManagerConfigWidget::addAspectToWorkingCopy(KitAspect *aspect)
{ {
QTC_ASSERT(aspect, return);
KitAspectWidget *widget = aspect->createConfigWidget(workingCopy());
QTC_ASSERT(widget, return); QTC_ASSERT(widget, return);
QTC_ASSERT(!m_widgets.contains(widget), return); QTC_ASSERT(!m_widgets.contains(widget), return);

2
src/plugins/projectexplorer/kitmanagerconfigwidget.h
View File

@@ -60,7 +60,7 @@ public:
bool isValid() const; bool isValid() const;
bool hasWarning() const; bool hasWarning() const;
QString validityMessage() const; QString validityMessage() const;
void addConfigWidget(KitAspectWidget *widget); void addAspectToWorkingCopy(KitAspect *aspect);
void makeStickySubWidgetsReadOnly(); void makeStickySubWidgetsReadOnly();
Kit *workingCopy() const; Kit *workingCopy() const;