From 1d53e37b6de255b2abcf62dedcac83128970f1ba Mon Sep 17 00:00:00 2001 From: Thomas Hartmann Date: Fri, 21 Aug 2020 17:18:53 +0200 Subject: [PATCH] QmlDesigner: Remove unused custom notification This notification is only for debugging and breaks encapsulation. Change-Id: I20faeb76d24cc42417b3cc2e289041c70edd6157 Reviewed-by: Marco Bubke --- src/plugins/qmldesigner/components/debugview/debugview.cpp | 5 +---- .../qmldesigner/designercore/instances/puppetcreator.cpp | 3 --- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/plugins/qmldesigner/components/debugview/debugview.cpp b/src/plugins/qmldesigner/components/debugview/debugview.cpp index 6805f7b44fc..61c6830b11c 100644 --- a/src/plugins/qmldesigner/components/debugview/debugview.cpp +++ b/src/plugins/qmldesigner/components/debugview/debugview.cpp @@ -422,10 +422,7 @@ void DebugView::instancesChildrenChanged(const QVector & nodeList) void DebugView::customNotification(const AbstractView *view, const QString &identifier, const QList &nodeList, const QList &data) { - if (identifier == "PuppetStatus" && data.count() == 1) { - m_debugViewWidget->setPuppetStatus(data.constFirst().toString()); - - } else if (isDebugViewEnabled()) { + if (isDebugViewEnabled()) { QTextStream message; QString string; message.setString(&string); diff --git a/src/plugins/qmldesigner/designercore/instances/puppetcreator.cpp b/src/plugins/qmldesigner/designercore/instances/puppetcreator.cpp index bdae76c0d3f..136b51150d2 100644 --- a/src/plugins/qmldesigner/designercore/instances/puppetcreator.cpp +++ b/src/plugins/qmldesigner/designercore/instances/puppetcreator.cpp @@ -495,9 +495,6 @@ QProcessEnvironment PuppetCreator::processEnvironment() const } #ifndef QMLDESIGNER_TEST - auto view = QmlDesignerPlugin::instance()->viewManager().nodeInstanceView(); - view->emitCustomNotification("PuppetStatus", {}, {QVariant(m_qrcMapping)}); - // set env var if QtQuick3D import exists QmlDesigner::Import import = QmlDesigner::Import::createLibraryImport("QtQuick3D", "1.0"); if (m_model->hasImport(import, true, true))