feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

DocumentClangToolRunner: Remove no-op call to disconnect

Browse Source 
A call to disconnect() prior to object destruction is no-op.

Change-Id: I719d84d5fde43038c80bd2fc164ffe5e0aab1fec
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Jarek Kobus
2022-06-17 11:45:59 +02:00
parent fd5bcea5f6
commit 1d67bf597f
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/clangtools/documentclangtoolrunner.cpp
View File

@@ -364,10 +364,7 @@ void DocumentClangToolRunner::cancel()
if (m_projectSettingsUpdate)
disconnect(m_projectSettingsUpdate);
m_runnerCreators.clear();
if (m_currentRunner) {
m_currentRunner->disconnect(this);
m_currentRunner.reset(nullptr);
}
m_currentRunner.reset(nullptr);
}
bool DocumentClangToolRunner::isSuppressed(const Diagnostic &diagnostic) const