feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Remove some useless Core::Id(...) and ProjectExplorer::

Browse Source 
Change-Id: Iebf4302bb5e3f893dc573e504efc214861d80848
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
This commit is contained in:
Tobias Hunger
2013-08-19 15:51:26 +02:00
parent c821e7c5ed
commit 1dd44cfba1
8 changed files with 58 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/projectexplorer/clangparser.cpp
View File

@@ -63,7 +63,7 @@ void ClangParser::stdError(const QString &line)
m_commandRegExp.cap(4),
Utils::FileName(), /* filename */
-1, /* line */
Core::Id(Constants::TASK_CATEGORY_COMPILE));
Constants::TASK_CATEGORY_COMPILE);
if (m_commandRegExp.cap(3) == QLatin1String("warning"))
task.type = Task::Warning;
else if (m_commandRegExp.cap(3) == QLatin1String("note"))
@@ -78,7 +78,7 @@ void ClangParser::stdError(const QString &line)
lne.trimmed(),
Utils::FileName::fromUserInput(m_inLineRegExp.cap(2)), /* filename */
m_inLineRegExp.cap(3).toInt(), /* line */
Core::Id(Constants::TASK_CATEGORY_COMPILE)));
Constants::TASK_CATEGORY_COMPILE));
return;
}
@@ -127,7 +127,7 @@ void ProjectExplorerPlugin::testClangOutputParser_data()
QTest::addColumn<QList<ProjectExplorer::Task> >("tasks");
QTest::addColumn<QString>("outputLines");
const Core::Id categoryCompile = Core::Id(Constants::TASK_CATEGORY_COMPILE);
const Core::Id categoryCompile = Constants::TASK_CATEGORY_COMPILE;
QTest::newRow("pass-through stdout")
<< QString::fromLatin1("Sometext") << OutputParserTester::STDOUT