From 1ddee692009975d89b36c51cf5e30808776e38e3 Mon Sep 17 00:00:00 2001 From: David Schulz Date: Fri, 1 Dec 2017 13:00:53 +0100 Subject: [PATCH] WinRT: fix saving changed deployment steps Explicitly connect ui elements to slots. Change-Id: I1235f29a1596636dffc943c276da4a251deca884 Reviewed-by: hjk --- .../winrt/winrtpackagedeploymentstepwidget.cpp | 11 +++++------ src/plugins/winrt/winrtpackagedeploymentstepwidget.h | 3 +-- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/plugins/winrt/winrtpackagedeploymentstepwidget.cpp b/src/plugins/winrt/winrtpackagedeploymentstepwidget.cpp index c7ef43bda00..c7198717b5d 100644 --- a/src/plugins/winrt/winrtpackagedeploymentstepwidget.cpp +++ b/src/plugins/winrt/winrtpackagedeploymentstepwidget.cpp @@ -38,6 +38,10 @@ WinRtPackageDeploymentStepWidget::WinRtPackageDeploymentStepWidget(WinRtPackageD m_ui->setupUi(this); m_ui->leArguments->setText(m_step->winDeployQtArguments()); m_ui->btnRestoreDefaultArgs->setIcon(Utils::Icons::RESET.icon()); + connect(m_ui->btnRestoreDefaultArgs, &QToolButton::pressed, + this, &WinRtPackageDeploymentStepWidget::restoreDefaultArguments); + connect(m_ui->leArguments, &QLineEdit::textChanged, + m_step, &WinRtPackageDeploymentStep::setWinDeployQtArguments); } WinRtPackageDeploymentStepWidget::~WinRtPackageDeploymentStepWidget() @@ -55,15 +59,10 @@ QString WinRtPackageDeploymentStepWidget::displayName() const return m_step->displayName(); } -void WinRtPackageDeploymentStepWidget::on_btnRestoreDefaultArgs_clicked() +void WinRtPackageDeploymentStepWidget::restoreDefaultArguments() { m_ui->leArguments->setText(m_step->defaultWinDeployQtArguments()); } -void WinRtPackageDeploymentStepWidget::on_leArguments_textChanged(QString str) -{ - m_step->setWinDeployQtArguments(str); -} - } // namespace Internal } // namespace WinRt diff --git a/src/plugins/winrt/winrtpackagedeploymentstepwidget.h b/src/plugins/winrt/winrtpackagedeploymentstepwidget.h index 31a30aaff6a..2a7f92f6467 100644 --- a/src/plugins/winrt/winrtpackagedeploymentstepwidget.h +++ b/src/plugins/winrt/winrtpackagedeploymentstepwidget.h @@ -45,8 +45,7 @@ public: virtual QString displayName() const; private: - void on_btnRestoreDefaultArgs_clicked(); - void on_leArguments_textChanged(QString str); + void restoreDefaultArguments(); Ui::WinRtPackageDeploymentStepWidget *m_ui; WinRtPackageDeploymentStep *m_step;