From 1de9e9e4026d105d6298462d03f03df3dc8a6f4d Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Wed, 11 Mar 2020 17:23:12 +0100 Subject: [PATCH] Android: Add missing reset of state variable The m_skipBuilding variable in AndroidBuildApkStep needs to be re- calculated on every call to init(). Also add some debug statements that will help us find out why it becomes true in the first place. Task-number: QTCREATORBUG-23572 Change-Id: I058b58cf0e511557d1fad7e5bd03048a7d8b9c69 Reviewed-by: BogDan Vatra --- src/plugins/android/androidbuildapkstep.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/plugins/android/androidbuildapkstep.cpp b/src/plugins/android/androidbuildapkstep.cpp index 25af2c8eca4..5f31ca86207 100644 --- a/src/plugins/android/androidbuildapkstep.cpp +++ b/src/plugins/android/androidbuildapkstep.cpp @@ -230,9 +230,11 @@ bool AndroidBuildApkStep::init() m_inputFile = node->data(Constants::AndroidDeploySettingsFile).toString(); if (m_inputFile.isEmpty()) { + qCDebug(buildapkstepLog) << "no input file" << rc << node << buildKey; m_skipBuilding = true; return true; } + m_skipBuilding = false; if (m_buildTargetSdk.isEmpty()) { emit addOutput(tr("Android build SDK not defined. Check Android settings."),