Meson: Merge tooltreeitem into toolsmodel

Change-Id: I949e36740545ea1521a22efb6b1db16548dfae64
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
hjk
2024-07-24 09:06:49 +02:00
parent 4fb63e4c9d
commit 1decf593b1
8 changed files with 150 additions and 193 deletions

View File

@@ -3,24 +3,129 @@
#include "toolsmodel.h"
#include "tooltreeitem.h"
#include "mesonprojectmanagertr.h"
#include "mesontools.h"
#include <projectexplorer/projectexplorerconstants.h>
#include <utils/qtcassert.h>
#include <utils/stringutils.h>
#include <utils/utilsicons.h>
namespace MesonProjectManager {
namespace Internal {
using namespace Utils;
namespace MesonProjectManager::Internal {
// ToolTreeItem
ToolTreeItem::ToolTreeItem(const QString &name)
: m_name{name}
, m_id(Id::generate())
, m_autoDetected{false}
, m_unsavedChanges{true}
{
self_check();
update_tooltip();
}
ToolTreeItem::ToolTreeItem(const MesonTools::Tool_t &tool)
: m_name{tool->name()}
, m_executable{tool->exe()}
, m_id{tool->id()}
, m_autoDetected{tool->autoDetected()}
{
m_tooltip = Tr::tr("Version: %1").arg(tool->version().toQString());
self_check();
}
ToolTreeItem::ToolTreeItem(const ToolTreeItem &other)
: m_name{Tr::tr("Clone of %1").arg(other.m_name)}
, m_executable{other.m_executable}
, m_id{Id::generate()}
, m_autoDetected{false}
, m_unsavedChanges{true}
{
self_check();
update_tooltip();
}
QVariant ToolTreeItem::data(int column, int role) const
{
switch (role) {
case Qt::DisplayRole: {
switch (column) {
case 0: {
return m_name;
}
case 1: {
return m_executable.toUserOutput();
}
} // switch (column)
return QVariant();
}
case Qt::FontRole: {
QFont font;
font.setBold(m_unsavedChanges);
return font;
}
case Qt::ToolTipRole: {
if (!m_pathExists)
return Tr::tr("Meson executable path does not exist.");
if (!m_pathIsFile)
return Tr::tr("Meson executable path is not a file.");
if (!m_pathIsExecutable)
return Tr::tr("Meson executable path is not executable.");
return m_tooltip;
}
case Qt::DecorationRole: {
if (column == 0 && (!m_pathExists || !m_pathIsFile || !m_pathIsExecutable))
return Icons::CRITICAL.icon();
return {};
}
}
return {};
}
void ToolTreeItem::update(const QString &name, const FilePath &exe)
{
m_unsavedChanges = true;
m_name = name;
if (exe != m_executable) {
m_executable = exe;
self_check();
update_tooltip();
}
}
void ToolTreeItem::self_check()
{
m_pathExists = m_executable.exists();
m_pathIsFile = m_executable.toFileInfo().isFile();
m_pathIsExecutable = m_executable.toFileInfo().isExecutable();
}
void ToolTreeItem::update_tooltip(const Version &version)
{
if (version.isValid)
m_tooltip = Tr::tr("Version: %1").arg(version.toQString());
else
m_tooltip = Tr::tr("Cannot get tool version.");
}
void ToolTreeItem::update_tooltip()
{
update_tooltip(ToolWrapper::read_version(m_executable));
}
// ToolsModel
ToolsModel::ToolsModel()
{
setHeader({Tr::tr("Name"), Tr::tr("Location")});
rootItem()->appendChild(
new Utils::StaticTreeItem({ProjectExplorer::Constants::msgAutoDetected()},
{ProjectExplorer::Constants::msgAutoDetectedToolTip()}));
rootItem()->appendChild(new Utils::StaticTreeItem(ProjectExplorer::Constants::msgManual()));
new StaticTreeItem({ProjectExplorer::Constants::msgAutoDetected()},
{ProjectExplorer::Constants::msgAutoDetectedToolTip()}));
rootItem()->appendChild(new StaticTreeItem(ProjectExplorer::Constants::msgManual()));
for (const auto &tool : MesonTools::tools())
addMesonToolHelper(tool);
}
@@ -30,7 +135,7 @@ ToolTreeItem *ToolsModel::mesoneToolTreeItem(const QModelIndex &index) const
return itemForIndexAtLevel<2>(index);
}
void ToolsModel::updateItem(const Utils::Id &itemId, const QString &name, const Utils::FilePath &exe)
void ToolsModel::updateItem(const Id &itemId, const QString &name, const FilePath &exe)
{
auto treeItem = findItemAtLevel<2>([itemId](ToolTreeItem *n) { return n->id() == itemId; });
QTC_ASSERT(treeItem, return );
@@ -45,7 +150,7 @@ void ToolsModel::addMesonTool()
void ToolsModel::removeMesonTool(ToolTreeItem *item)
{
QTC_ASSERT(item, return );
const Utils::Id id = item->id();
const Id id = item->id();
destroyItem(item);
m_itemsToRemove.enqueue(id);
}
@@ -83,19 +188,18 @@ void ToolsModel::addMesonToolHelper(const MesonTools::Tool_t &tool)
QString ToolsModel::uniqueName(const QString &baseName)
{
QStringList names;
forItemsAtLevel<2>([&names](auto *item) { names << item->name(); });
forItemsAtLevel<2>([&names](ToolTreeItem *item) { names << item->name(); });
return Utils::makeUniquelyNumbered(baseName, names);
}
Utils::TreeItem *ToolsModel::autoDetectedGroup() const
TreeItem *ToolsModel::autoDetectedGroup() const
{
return rootItem()->childAt(0);
}
Utils::TreeItem *ToolsModel::manualGroup() const
TreeItem *ToolsModel::manualGroup() const
{
return rootItem()->childAt(1);
}
} // namespace Internal
} // namespace MesonProjectManager
} // MesonProjectManager::Internal