From 1e0523423ad4f05c978dbe554f0badd48bab5f8d Mon Sep 17 00:00:00 2001
From: Nikolai Kosjar <nikolai.kosjar@qt.io>
Date: Fri, 30 Aug 2019 16:15:43 +0200
Subject: [PATCH] ClangTools: Fix saving files before analyzing

...in current file mode.

Change-Id: Iae2ca9dc0ba5325f485943deb7fd93b3e9b419fe
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
---
 src/plugins/clangtools/clangtoolruncontrol.cpp | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/src/plugins/clangtools/clangtoolruncontrol.cpp b/src/plugins/clangtools/clangtoolruncontrol.cpp
index 3db1998bf6b..da8e9f053cb 100644
--- a/src/plugins/clangtools/clangtoolruncontrol.cpp
+++ b/src/plugins/clangtools/clangtoolruncontrol.cpp
@@ -128,18 +128,11 @@ public:
         setId("ProjectBuilder");
     }
 
-    void setEnabled(bool enabled) { m_enabled = enabled; }
     bool success() const { return m_success; }
 
 private:
     void start() final
     {
-        if (!m_enabled) {
-            ProjectExplorerPlugin::saveModifiedFiles();
-            onBuildFinished(true);
-            return;
-        }
-
         Target *target = runControl()->target();
         QTC_ASSERT(target, reportFailure(); return);
 
@@ -185,7 +178,6 @@ private:
      }
 
 private:
-     bool m_enabled = true;
      bool m_success = false;
 };
 
@@ -243,10 +235,9 @@ ClangToolRunWorker::ClangToolRunWorker(RunControl *runControl,
     setId("ClangTidyClazyRunner");
     setSupportsReRunning(false);
 
-    if (!preventBuild) {
+    if (!preventBuild && ClangToolsSettings::instance()->savedBuildBeforeAnalysis()) {
         m_projectBuilder = new ProjectBuilder(runControl);
         addStartDependency(m_projectBuilder);
-        m_projectBuilder->setEnabled(ClangToolsSettings::instance()->savedBuildBeforeAnalysis());
     }
 
     Target *target = runControl->target();
@@ -283,6 +274,7 @@ QList<RunnerCreator> ClangToolRunWorker::runnerCreators()
 void ClangToolRunWorker::start()
 {
     TaskHub::clearTasks(Debugger::Constants::ANALYZERTASK_ID);
+    ProjectExplorerPlugin::saveModifiedFiles();
 
     if (ClangToolsSettings::instance()->savedBuildBeforeAnalysis()) {
         if (m_projectBuilder && !m_projectBuilder->success()) {