feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangCodeModel: Suppress broken clang fix-it (again)

Browse Source 
This time with clangd.

Fixes: QTCREATORBUG-18593
Change-Id: I26cedec0dcdf07c46ae96a5d714df128dfcd2d26
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Kandeler
2022-05-13 17:13:02 +02:00
parent 6006ec8180
commit 1e25be0cfd
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/clangcodemodel/clangdclient.cpp
View File

@@ -3399,7 +3399,19 @@ IAssistProcessor *ClangdClient::VirtualFunctionAssistProvider::createProcessor(
Utils::optional<QList<CodeAction> > ClangdDiagnostic::codeActions() const Utils::optional<QList<CodeAction> > ClangdDiagnostic::codeActions() const
{ {
return optionalArray<LanguageServerProtocol::CodeAction>("codeActions"); auto actions = optionalArray<LanguageServerProtocol::CodeAction>("codeActions");
if (!actions)
return actions;
static const QStringList badCodeActions{
"remove constant to silence this warning", // QTCREATORBUG-18593
};
for (auto it = actions->begin(); it != actions->end();) {
if (badCodeActions.contains(it->title()))
it = actions->erase(it);
else
++it;
}
return actions;
} }
QString ClangdDiagnostic::category() const QString ClangdDiagnostic::category() const