From 1e35f09251d16f3d72bac759e5c25161a6a3828a Mon Sep 17 00:00:00 2001 From: hjk Date: Tue, 18 Jul 2023 13:54:51 +0200 Subject: [PATCH] Core: Remove PagedSettings again Turned out to create a too strict tie between settings and settings pages, we are more flexible with delaying/avoiding initialization without these. Change-Id: I948af675e29c7da34bfccd490c1c1b999923f279 Reviewed-by: Jarek Kobus --- src/plugins/coreplugin/dialogs/ioptionspage.cpp | 8 -------- src/plugins/coreplugin/dialogs/ioptionspage.h | 6 ------ 2 files changed, 14 deletions(-) diff --git a/src/plugins/coreplugin/dialogs/ioptionspage.cpp b/src/plugins/coreplugin/dialogs/ioptionspage.cpp index ffd27f85725..dc751eddc98 100644 --- a/src/plugins/coreplugin/dialogs/ioptionspage.cpp +++ b/src/plugins/coreplugin/dialogs/ioptionspage.cpp @@ -314,12 +314,4 @@ const QList IOptionsPageProvider::allOptionsPagesProvide return g_optionsPagesProviders; } -// PagedSettings - -PagedSettings::PagedSettings() -{ - setSettings(this); - setAutoApply(false); -} - } // Core diff --git a/src/plugins/coreplugin/dialogs/ioptionspage.h b/src/plugins/coreplugin/dialogs/ioptionspage.h index c8e78545e68..54617d6e602 100644 --- a/src/plugins/coreplugin/dialogs/ioptionspage.h +++ b/src/plugins/coreplugin/dialogs/ioptionspage.h @@ -120,10 +120,4 @@ protected: Utils::FilePath m_categoryIconPath; }; -class CORE_EXPORT PagedSettings : public Utils::AspectContainer, public IOptionsPage -{ -public: - PagedSettings(); -}; - } // namespace Core