feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlProfiler: Avoid empty timeline when restricting to ranges

Browse Source 
The timeline models were suspended for editing but never restored. To
test the correct behavior a test case for the trace view is added.

Change-Id: Ic1803e9d84656eed97795f1f1674e3d56c83f650
Task-number: QTCREATORBUG-18354
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Ulf Hermann
2017-08-07 12:05:11 +02:00
parent 48d3fd1af5
commit 1e781cd396
7 changed files with 139 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

67
src/plugins/qmlprofiler/tests/qmlprofilertraceview_test.cpp Normal file
View File

@@ -0,0 +1,67 @@
/****************************************************************************
**
** Copyright (C) 2017 The Qt Company Ltd.
** Contact: https://www.qt.io/licensing/
**
** This file is part of Qt Creator.
**
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and The Qt Company. For licensing terms
** and conditions see https://www.qt.io/terms-conditions. For further
** information use the contact form at https://www.qt.io/contact-us.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3 as published by the Free Software
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
** included in the packaging of this file. Please review the following
** information to ensure the GNU General Public License requirements will
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
**
****************************************************************************/
#include "qmlprofilertraceview_test.h"
#include <QtTest>
namespace QmlProfiler {
namespace Internal {
QmlProfilerTraceViewTest::QmlProfilerTraceViewTest(QObject *parent) :
QObject(parent), traceView(nullptr, nullptr, &modelManager)
{
}
void QmlProfilerTraceViewTest::testStateChanges()
{
// Standard acquire-process-clear work flow
modelManager.startAcquiring();
QVERIFY(traceView.isSuspended());
modelManager.acquiringDone();
QVERIFY(!traceView.isSuspended());
modelManager.clear();
QVERIFY(!traceView.isSuspended());
// Restrict to range
modelManager.startAcquiring();
QVERIFY(traceView.isSuspended());
modelManager.acquiringDone();
QVERIFY(!traceView.isSuspended());
modelManager.restrictToRange(10, 14);
QVERIFY(!traceView.isSuspended());
modelManager.restrictToRange(-1, -1);
QVERIFY(!traceView.isSuspended());
modelManager.clear();
QVERIFY(!traceView.isSuspended());
// Abort Acquiring
modelManager.startAcquiring();
QVERIFY(traceView.isSuspended());
modelManager.clear();
QVERIFY(!traceView.isSuspended());
}
} // namespace Internal
} // namespace QmlProfiler