feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Clangbackend: Use Qt debugging instead of std::cerr

Browse Source 
The arguments passed to libclang were only passed to std::cerr,
which and never reached Windows logging.

On Windows the clang*.exe have a qMessageHandler which forwards
the message to windows logging and std::cerr.

Change-Id: I97b0856ae2b3f44a991c9d292a15db9f3b071a0d
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
This commit is contained in:
Cristian Adam
2019-09-24 10:46:13 +02:00
parent bcaeb73e68
commit 1e9b1dcaec
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/tools/clangbackend/source/commandlinearguments.cpp
View File

@@ -32,9 +32,7 @@
#include <utils/qtcprocess.h> #include <utils/qtcprocess.h>
#include <QByteArray> #include <QByteArray>
#include <QtCore/qdebug.h> #include <QDebug>
#include <iostream>
static QList<QByteArray> splitArgs(QString &argsString) static QList<QByteArray> splitArgs(QString &argsString)
{ {
@@ -121,11 +119,10 @@ static Utf8String maybeQuoted(const char *argumentAsCString)
void CommandLineArguments::print() const void CommandLineArguments::print() const
{ {
using namespace std; auto cerr = qCritical();
cerr << "Arguments to libclang:"; cerr << "Arguments to libclang:";
for (const auto &argument : m_arguments) for (const auto &argument : m_arguments)
cerr << ' ' << maybeQuoted(argument).constData(); cerr.noquote() << maybeQuoted(argument).constData();
cerr << endl;
} }
} // namespace ClangBackEnd } // namespace ClangBackEnd