From 1e9e09d7656b89b7fd2dda24769fc3e240e42053 Mon Sep 17 00:00:00 2001 From: Cristian Adam Date: Thu, 31 Mar 2022 17:30:02 +0200 Subject: [PATCH] CMakePM: Filter out (more) empty key configuration items The code was not filtering empty configuration items that were the result of bad string input like: -DMY_KEY:PATH/some/path/but/no/equal/sign Amends a2a8f56b6e7429ddf7f26052dd92276938cd3d21 Task-number: QTCREATORBUG-27237 Change-Id: Ic307eceb66dc0e00b073c9aabb04fe70a223cf08 Reviewed-by: Eike Ziller --- src/plugins/cmakeprojectmanager/cmakeconfigitem.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/plugins/cmakeprojectmanager/cmakeconfigitem.cpp b/src/plugins/cmakeprojectmanager/cmakeconfigitem.cpp index ad9c2277928..002ece93261 100644 --- a/src/plugins/cmakeprojectmanager/cmakeconfigitem.cpp +++ b/src/plugins/cmakeprojectmanager/cmakeconfigitem.cpp @@ -349,7 +349,8 @@ CMakeConfig CMakeConfig::fromArguments(const QStringList &list, QStringList &unk unknownOptions.append(i); } - return result; + + return Utils::filtered(result, [](const CMakeConfigItem &item) { return !item.key.isEmpty(); }); } CMakeConfig CMakeConfig::fromFile(const Utils::FilePath &cacheFile, QString *errorMessage)