forked from qt-creator/qt-creator
Clang: Provide example with clazy warnings
Change-Id: I23cb81d0ffe0d23428ce85ba22d85e1d6c8c1216 Reviewed-by: Marco Bubke <marco.bubke@qt.io>
This commit is contained in:
138
share/qtcreator/cplusplus/examples/clazy_example.cpp
Normal file
138
share/qtcreator/cplusplus/examples/clazy_example.cpp
Normal file
@@ -0,0 +1,138 @@
|
|||||||
|
/****************************************************************************
|
||||||
|
**
|
||||||
|
** Copyright (C) 2018 The Qt Company Ltd.
|
||||||
|
** Contact: https://www.qt.io/licensing/
|
||||||
|
**
|
||||||
|
** This file is part of Qt Creator.
|
||||||
|
**
|
||||||
|
** Commercial License Usage
|
||||||
|
** Licensees holding valid commercial Qt licenses may use this file in
|
||||||
|
** accordance with the commercial license agreement provided with the
|
||||||
|
** Software or, alternatively, in accordance with the terms contained in
|
||||||
|
** a written agreement between you and The Qt Company. For licensing terms
|
||||||
|
** and conditions see https://www.qt.io/terms-conditions. For further
|
||||||
|
** information use the contact form at https://www.qt.io/contact-us.
|
||||||
|
**
|
||||||
|
** GNU General Public License Usage
|
||||||
|
** Alternatively, this file may be used under the terms of the GNU
|
||||||
|
** General Public License version 3 as published by the Free Software
|
||||||
|
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
|
||||||
|
** included in the packaging of this file. Please review the following
|
||||||
|
** information to ensure the GNU General Public License requirements will
|
||||||
|
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
|
||||||
|
**
|
||||||
|
****************************************************************************/
|
||||||
|
|
||||||
|
// -Wclazy-qt-macros
|
||||||
|
#ifdef Q_OS_XXX
|
||||||
|
#endif
|
||||||
|
|
||||||
|
#include <QCoreApplication>
|
||||||
|
#include <QDateTime>
|
||||||
|
#include <QFileInfo>
|
||||||
|
#include <QMap>
|
||||||
|
#include <QObject>
|
||||||
|
#include <QPoint>
|
||||||
|
#include <QPointer>
|
||||||
|
|
||||||
|
// -Wclazy-ctor-missing-parent-argument
|
||||||
|
class TestObject : public QObject
|
||||||
|
{
|
||||||
|
Q_OBJECT
|
||||||
|
|
||||||
|
public:
|
||||||
|
TestObject();
|
||||||
|
TestObject(const TestObject& other);
|
||||||
|
|
||||||
|
bool event(QEvent *event) override
|
||||||
|
{
|
||||||
|
// -Wclazy-base-class-event
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
public slots:
|
||||||
|
void someSlot();
|
||||||
|
|
||||||
|
// -Wclazy-function-args-by-value
|
||||||
|
void someOtherSlot(const QPoint &point)
|
||||||
|
{
|
||||||
|
point.isNull();
|
||||||
|
}
|
||||||
|
|
||||||
|
signals:
|
||||||
|
void someSignal();
|
||||||
|
private:
|
||||||
|
char m_bigArray[100];
|
||||||
|
};
|
||||||
|
|
||||||
|
// -Wclazy-copyable-polymorphic
|
||||||
|
class TestObjectDerived : public TestObject
|
||||||
|
{
|
||||||
|
|
||||||
|
};
|
||||||
|
|
||||||
|
QList<int> getList()
|
||||||
|
{
|
||||||
|
QList<int> list;
|
||||||
|
return list;
|
||||||
|
}
|
||||||
|
|
||||||
|
TestObject::TestObject()
|
||||||
|
{
|
||||||
|
// -Wclazy-old-style-connect
|
||||||
|
QObject::connect(this, SIGNAL(someSlot()), SLOT(someOtherSlot()));
|
||||||
|
|
||||||
|
int a;
|
||||||
|
|
||||||
|
// -Wclazy-connect-non-signal, -Wclazy-lambda-in-connect
|
||||||
|
QObject::connect(this, &TestObject::someSlot, [&a]() {
|
||||||
|
return;
|
||||||
|
});
|
||||||
|
|
||||||
|
// -Wclazy-incorrect-emit
|
||||||
|
someSignal();
|
||||||
|
|
||||||
|
QMap<int, int *> map;
|
||||||
|
|
||||||
|
// -Wclazy-unused-non-trivial-variable, -Wclazy-mutable-container-key
|
||||||
|
QMap<QPointer<QObject>, int> map2;
|
||||||
|
|
||||||
|
// -Wclazy-container-anti-pattern, -Wclazy-range-loop
|
||||||
|
for (auto value : map.values()) {
|
||||||
|
}
|
||||||
|
|
||||||
|
// -Wclazy-qdeleteall
|
||||||
|
qDeleteAll(map.values());
|
||||||
|
for (auto it = getList().begin(); it != getList().end(); ++it) { // -Wclazy-detaching-temporary, -Wclazy-temporary-iterator
|
||||||
|
}
|
||||||
|
|
||||||
|
// -Wclazy-inefficient-qlist-soft
|
||||||
|
QList<TestObject> list;
|
||||||
|
|
||||||
|
// -Wclazy-range-loop
|
||||||
|
for (auto obj : list) {
|
||||||
|
}
|
||||||
|
|
||||||
|
// -Wclazy-qdatetime-utc
|
||||||
|
QDateTime::currentDateTime().toTime_t();
|
||||||
|
|
||||||
|
// -Wclazy-qfileinfo-exists
|
||||||
|
// -Wclazy-qstring-allocations
|
||||||
|
QFileInfo("filename").exists();
|
||||||
|
|
||||||
|
// -Wclazy-qlatin1string-non-ascii
|
||||||
|
QLatin1String latinStr("ййй");
|
||||||
|
|
||||||
|
QString str = latinStr;
|
||||||
|
|
||||||
|
// -Wclazy-qstring-left
|
||||||
|
str = str.left(1);
|
||||||
|
|
||||||
|
bool ok;
|
||||||
|
|
||||||
|
// -Wclazy-qstring-ref
|
||||||
|
str.mid(5).toInt(&ok);
|
||||||
|
|
||||||
|
// -Wclazy-qstring-arg
|
||||||
|
QString("%1 %2").arg("1").arg("2");
|
||||||
|
}
|
@@ -4,6 +4,6 @@ CONFIG+= c++1z
|
|||||||
|
|
||||||
TARGET = examples
|
TARGET = examples
|
||||||
|
|
||||||
SOURCES += tidy_example.cpp
|
SOURCES += clazy_example.cpp tidy_example.cpp
|
||||||
|
|
||||||
HEADERS += tidy_example.h
|
HEADERS += tidy_example.h
|
||||||
|
Reference in New Issue
Block a user