From 1ee4b0e58337e90481caa715c652e42faeae7ecb Mon Sep 17 00:00:00 2001
From: Jarek Kobus <jaroslaw.kobus@qt.io>
Date: Wed, 14 Dec 2022 13:20:38 +0100
Subject: [PATCH] CorePlugin: Don't call mutable expressions inside QTC_ASSERT

In order to conform to the theory: "Removing all
QTC_ASSERTs and QTC_CHECKs should not change anything".

Change-Id: I95593962486e1de1b980f17b8f924d6f98fa8e80
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
---
 src/plugins/coreplugin/corejsextensions.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/plugins/coreplugin/corejsextensions.cpp b/src/plugins/coreplugin/corejsextensions.cpp
index a7934e2ede4..65fbbcc9db6 100644
--- a/src/plugins/coreplugin/corejsextensions.cpp
+++ b/src/plugins/coreplugin/corejsextensions.cpp
@@ -132,7 +132,8 @@ QString UtilsJsExtension::mktemp(const QString &pattern) const
 
     QTemporaryFile file(tmp);
     file.setAutoRemove(false);
-    QTC_ASSERT(file.open(), return QString());
+    const bool isOpen = file.open();
+    QTC_ASSERT(isOpen, return {});
     file.close();
     return file.fileName();
 }