feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Cleanup more TODOs in ProjectExplorer

Browse Source 
Those are just comments on the code, nothing to do.

Change-Id: I1daaa26eafd3d5f4da1d4be3eede9996ea87248f
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
This commit is contained in:
Daniel Teske
2012-05-03 17:05:38 +02:00
parent 36500c212d
commit 1ee7205a82
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/projectexplorer/buildconfiguration.cpp
View File

@@ -199,7 +199,7 @@ bool BuildConfiguration::fromMap(const QVariantMap &map)
setToolChain(ToolChainManager::instance()->findToolChain(id)); // Do not validate the tool chain as setToolChain(ToolChainManager::instance()->findToolChain(id)); // Do not validate the tool chain as
// the BC is not completely set up yet! // the BC is not completely set up yet!
// TODO: We currently assume there to be at least a clean and build list! // We currently assume there to be at least a clean and build list!
QTC_CHECK(knownStepLists().contains(Core::Id(ProjectExplorer::Constants::BUILDSTEPS_BUILD))); QTC_CHECK(knownStepLists().contains(Core::Id(ProjectExplorer::Constants::BUILDSTEPS_BUILD)));
QTC_CHECK(knownStepLists().contains(Core::Id(ProjectExplorer::Constants::BUILDSTEPS_CLEAN))); QTC_CHECK(knownStepLists().contains(Core::Id(ProjectExplorer::Constants::BUILDSTEPS_CLEAN)));

2
src/plugins/projectexplorer/deployconfiguration.cpp
View File

@@ -127,7 +127,7 @@ bool DeployConfiguration::fromMap(const QVariantMap &map)
return false; return false;
} }
// TODO: We assume that we hold the deploy list // We assume that we hold the deploy list
Q_ASSERT(m_stepList && m_stepList->id() == Core::Id(ProjectExplorer::Constants::BUILDSTEPS_DEPLOY)); Q_ASSERT(m_stepList && m_stepList->id() == Core::Id(ProjectExplorer::Constants::BUILDSTEPS_DEPLOY));
return true; return true;

2
src/plugins/projectexplorer/session.cpp
View File

@@ -158,7 +158,7 @@ bool SessionManager::recursiveDependencyCheck(const QString &newDep, const QStri
} }
/* /*
* TODO: The dependency management exposes an interface based on projects, but * The dependency management exposes an interface based on projects, but
* is internally purely string based. This is suboptimal. Probably it would be * is internally purely string based. This is suboptimal. Probably it would be
* nicer to map the filenames to projects on load and only map it back to * nicer to map the filenames to projects on load and only map it back to
* filenames when saving. * filenames when saving.