feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlProfiler: Remove getState() methods

Browse Source 
A numerical representation of "state" is not so useful after all.

Change-Id: I7fc3ae08a2fd44000b5543f4ba25730a8d79358d
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
This commit is contained in:
Ulf Hermann
2014-07-08 12:49:56 +02:00
parent 5ceb0b68d6
commit 1f46fca305
5 changed files with 1 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/qmlprofiler/abstracttimelinemodel.cpp
View File

@@ -190,12 +190,6 @@ qint64 AbstractTimelineModel::traceDuration() const
return d->modelManager->traceTime()->duration(); return d->modelManager->traceTime()->duration();
} }
int AbstractTimelineModel::getState() const
{
Q_D(const AbstractTimelineModel);
return (int)d->modelManager->state();
}
const QVariantMap AbstractTimelineModel::getEventLocation(int index) const const QVariantMap AbstractTimelineModel::getEventLocation(int index) const
{ {
Q_UNUSED(index); Q_UNUSED(index);

1
src/plugins/qmlprofiler/abstracttimelinemodel.h
View File

@@ -62,7 +62,6 @@ public:
Q_INVOKABLE qint64 traceStartTime() const; Q_INVOKABLE qint64 traceStartTime() const;
Q_INVOKABLE qint64 traceEndTime() const; Q_INVOKABLE qint64 traceEndTime() const;
Q_INVOKABLE qint64 traceDuration() const; Q_INVOKABLE qint64 traceDuration() const;
Q_INVOKABLE int getState() const;
Q_INVOKABLE qint64 getDuration(int index) const; Q_INVOKABLE qint64 getDuration(int index) const;
Q_INVOKABLE qint64 getStartTime(int index) const; Q_INVOKABLE qint64 getStartTime(int index) const;
Q_INVOKABLE qint64 getEndTime(int index) const; Q_INVOKABLE qint64 getEndTime(int index) const;

7
src/plugins/qmlprofiler/qml/MainView.qml
View File

@@ -76,12 +76,6 @@ Rectangle {
Connections { Connections {
target: qmlProfilerModelProxy target: qmlProfilerModelProxy
onStateChanged: {
// Clear if model is empty.
if (qmlProfilerModelProxy.getState() === 0)
root.clear();
backgroundMarks.requestPaint()
}
onDataAvailable: { onDataAvailable: {
view.clearData(); view.clearData();
zoomControl.setRange(qmlProfilerModelProxy.traceStartTime(), zoomControl.setRange(qmlProfilerModelProxy.traceStartTime(),
@@ -89,6 +83,7 @@ Rectangle {
qmlProfilerModelProxy.traceDuration()/10); qmlProfilerModelProxy.traceDuration()/10);
view.requestPaint(); view.requestPaint();
} }
onStateChanged: backgroundMarks.requestPaint()
onExpandedChanged: backgroundMarks.requestPaint() onExpandedChanged: backgroundMarks.requestPaint()
onRowHeightChanged: backgroundMarks.requestPaint() onRowHeightChanged: backgroundMarks.requestPaint()
} }

6
src/plugins/qmlprofiler/timelinemodelaggregator.cpp
View File

@@ -286,11 +286,5 @@ qint64 TimelineModelAggregator::traceDuration() const
return d->modelManager->traceTime()->duration(); return d->modelManager->traceTime()->duration();
} }
int TimelineModelAggregator::getState() const
{
return (int)d->modelManager->state();
}
} // namespace Internal } // namespace Internal
} // namespace QmlProfiler } // namespace QmlProfiler

1
src/plugins/qmlprofiler/timelinemodelaggregator.h
View File

@@ -54,7 +54,6 @@ public:
Q_INVOKABLE qint64 traceStartTime() const; Q_INVOKABLE qint64 traceStartTime() const;
Q_INVOKABLE qint64 traceEndTime() const; Q_INVOKABLE qint64 traceEndTime() const;
Q_INVOKABLE qint64 traceDuration() const; Q_INVOKABLE qint64 traceDuration() const;
Q_INVOKABLE int getState() const;
bool isEmpty() const; bool isEmpty() const;