feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CodeStylePool: Avoid using sender()

Browse Source 
Change-Id: I72bf94a7d0a3c4e583016e1cffacba4b246bd858
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2022-07-20 18:55:58 +02:00
parent 74046fa1f5
commit 1f4a3447be
2 changed files with 4 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/plugins/texteditor/codestylepool.cpp
View File

@@ -174,12 +174,10 @@ void CodeStylePool::addCodeStyle(ICodeStylePreferences *codeStyle)
// take ownership // take ownership
codeStyle->setParent(this); codeStyle->setParent(this);
connect(codeStyle, &ICodeStylePreferences::valueChanged, auto doSaveStyle = [this, codeStyle] { saveCodeStyle(codeStyle); };
this, &CodeStylePool::slotSaveCodeStyle); connect(codeStyle, &ICodeStylePreferences::valueChanged, this, doSaveStyle);
connect(codeStyle, &ICodeStylePreferences::tabSettingsChanged, connect(codeStyle, &ICodeStylePreferences::tabSettingsChanged, this, doSaveStyle);
this, &CodeStylePool::slotSaveCodeStyle); connect(codeStyle, &ICodeStylePreferences::displayNameChanged, this, doSaveStyle);
connect(codeStyle, &ICodeStylePreferences::displayNameChanged,
this, &CodeStylePool::slotSaveCodeStyle);
emit codeStyleAdded(codeStyle); emit codeStyleAdded(codeStyle);
} }
@@ -250,15 +248,6 @@ ICodeStylePreferences *CodeStylePool::loadCodeStyle(const Utils::FilePath &fileN
return codeStyle; return codeStyle;
} }
void CodeStylePool::slotSaveCodeStyle()
{
auto codeStyle = qobject_cast<ICodeStylePreferences *>(sender());
if (!codeStyle)
return;
saveCodeStyle(codeStyle);
}
void CodeStylePool::saveCodeStyle(ICodeStylePreferences *codeStyle) const void CodeStylePool::saveCodeStyle(ICodeStylePreferences *codeStyle) const
{ {
const QString codeStylesPath = customCodeStylesPath().toString(); const QString codeStylesPath = customCodeStylesPath().toString();

2
src/plugins/texteditor/codestylepool.h
View File

@@ -69,8 +69,6 @@ signals:
void codeStyleRemoved(ICodeStylePreferences *); void codeStyleRemoved(ICodeStylePreferences *);
private: private:
void slotSaveCodeStyle();
QString settingsDir() const; QString settingsDir() const;
Utils::FilePath settingsPath(const QByteArray &id) const; Utils::FilePath settingsPath(const QByteArray &id) const;
ICodeStylePreferences *loadCodeStyle(const Utils::FilePath &fileName); ICodeStylePreferences *loadCodeStyle(const Utils::FilePath &fileName);