VCS: Unify displayName()

* Uppercase first letter or whole name
* Do not translate the name
* Move implementation to declaration to immediately
  see all names in Find Usages

Change-Id: I45f9b8bd8cfab46ab72548d22b140169880fe81f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>

src/plugins/bazaar/bazaarplugin.cpp

@@ -128,7 +128,7 @@ class BazaarPluginPrivate final : public VersionControlBase
 public:
     BazaarPluginPrivate();
 
-    QString displayName() const final;
+    QString displayName() const final { return "Bazaar"; }
     Utils::Id id() const final;
 
     bool isVcsFileOrDirectory(const Utils::FilePath &filePath) const final;
@@ -855,11 +855,6 @@ void BazaarPluginPrivate::updateActions(VersionControlBase::ActionState as)
         repoAction->setEnabled(repoEnabled);
 }
 
-QString BazaarPluginPrivate::displayName() const
-{
-    return Tr::tr("Bazaar");
-}
-
 Utils::Id BazaarPluginPrivate::id() const
 {
     return Utils::Id(VcsBase::Constants::VCS_ID_BAZAAR);

src/plugins/clearcase/clearcaseplugin.cpp

@@ -119,7 +119,7 @@ public:
     ~ClearCasePluginPrivate() final;
 
     // IVersionControl
-    QString displayName() const final;
+    QString displayName() const final { return "ClearCase"; }
     Id id() const final;
 
     bool isVcsFileOrDirectory(const FilePath &filePath) const final;
@@ -2302,11 +2302,6 @@ void ClearCasePluginPrivate::sync(QPromise<void> &promise, QStringList files)
     ccSync.run(promise, files);
 }
 
-QString ClearCasePluginPrivate::displayName() const
-{
-    return QLatin1String("ClearCase");
-}
-
 Id ClearCasePluginPrivate::id() const
 {
     return Constants::VCS_ID_CLEARCASE;

src/plugins/cvs/cvsplugin.cpp

@@ -158,7 +158,7 @@ public:
     ~CvsPluginPrivate() final;
 
     // IVersionControl
-    QString displayName() const final { return QLatin1String("cvs"); }
+    QString displayName() const final { return "CVS"; }
     Utils::Id id() const final;
 
     bool isVcsFileOrDirectory(const Utils::FilePath &filePath) const final;

src/plugins/fossil/fossilplugin.cpp

@@ -73,7 +73,7 @@ public:
     FossilPluginPrivate();
 
     // IVersionControl
-    QString displayName() const final;
+    QString displayName() const final { return "Fossil"; }
     Id id() const final;
 
     bool isVcsFileOrDirectory(const FilePath &filePath) const final;
@@ -778,11 +778,6 @@ void FossilPluginPrivate::updateActions(VersionControlBase::ActionState as)
         repoAction->setEnabled(repoEnabled);
 }
 
-QString FossilPluginPrivate::displayName() const
-{
-    return Tr::tr("Fossil");
-}
-
 Id FossilPluginPrivate::id() const
 {
     return Id(Constants::VCS_ID_FOSSIL);

src/plugins/git/gitplugin.cpp

@@ -147,7 +147,7 @@ public:
     ~GitPluginPrivate() final;
 
     // IVersionControl
-    QString displayName() const final;
+    QString displayName() const final { return "Git"; }
     Id id() const final;
 
     bool isVcsFileOrDirectory(const FilePath &filePath) const final;
@@ -1735,11 +1735,6 @@ void GitPluginPrivate::updateRepositoryBrowserAction()
     m_repositoryBrowserAction->setEnabled(repositoryEnabled && hasRepositoryBrowserCmd);
 }
 
-QString GitPluginPrivate::displayName() const
-{
-    return QLatin1String("Git");
-}
-
 Id GitPluginPrivate::id() const
 {
     return Id(VcsBase::Constants::VCS_ID_GIT);

src/plugins/mercurial/mercurialplugin.cpp

@@ -58,7 +58,7 @@ public:
     MercurialPluginPrivate();
 
     // IVersionControl
-    QString displayName() const final;
+    QString displayName() const final { return "Mercurial"; }
     Utils::Id id() const final;
     bool isVcsFileOrDirectory(const FilePath &filePath) const final;
 
@@ -640,11 +640,6 @@ void MercurialPluginPrivate::updateActions(VersionControlBase::ActionState as)
         repoAction->setEnabled(repoEnabled);
 }
 
-QString MercurialPluginPrivate::displayName() const
-{
-    return Tr::tr("Mercurial");
-}
-
 Utils::Id MercurialPluginPrivate::id() const
 {
     return {VcsBase::Constants::VCS_ID_MERCURIAL};

src/plugins/perforce/perforceplugin.cpp

@@ -151,7 +151,7 @@ public:
     PerforcePluginPrivate();
 
     // IVersionControl
-    QString displayName() const final { return {"perforce"}; }
+    QString displayName() const final { return "Perforce"; }
     Id id() const final { return VcsBase::Constants::VCS_ID_PERFORCE; }
 
     bool isVcsFileOrDirectory(const FilePath &filePath) const final;

src/plugins/subversion/subversionplugin.cpp

@@ -133,7 +133,7 @@ public:
     ~SubversionPluginPrivate() final;
 
     // IVersionControl
-    QString displayName() const final;
+    QString displayName() const final { return "Subversion"; }
     Utils::Id id() const final;
     bool isVcsFileOrDirectory(const FilePath &filePath) const final;
 
@@ -1050,11 +1050,6 @@ bool SubversionPluginPrivate::checkSVNSubDir(const QDir &directory) const
     return false;
 }
 
-QString SubversionPluginPrivate::displayName() const
-{
-    return QLatin1String("subversion");
-}
-
 Utils::Id SubversionPluginPrivate::id() const
 {
     return Utils::Id(VcsBase::Constants::VCS_ID_SUBVERSION);