feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LanguageClient: fix todo

Browse Source 
Change-Id: Ia6b3b5fe6e595c32a8b8a13b869f3178afb37ed8
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
David Schulz
2022-06-03 13:50:31 +02:00
parent 5693c518bc
commit 2029fe8c99
6 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/languageclient/languageclientsettings.cpp
View File

@@ -581,7 +581,7 @@ Client *BaseSettings::createClient(ProjectExplorer::Project *project) const
{
if (!isValid() || !m_enabled)
return nullptr;
BaseClientInterface *interface = createInterfaceWithProject(project);
BaseClientInterface *interface = createInterface(project);
QTC_ASSERT(interface, return nullptr);
auto *client = createClient(interface);
client->setName(Utils::globalMacroExpander()->expand(m_name));
@@ -592,6 +592,11 @@ Client *BaseSettings::createClient(ProjectExplorer::Project *project) const
return client;
}
BaseClientInterface *BaseSettings::createInterface(ProjectExplorer::Project *) const
{
return nullptr;
}
Client *BaseSettings::createClient(BaseClientInterface *interface) const
{
return new Client(interface);
@@ -772,7 +777,7 @@ Utils::CommandLine StdIOSettings::command() const
return Utils::CommandLine(m_executable, arguments(), Utils::CommandLine::Raw);
}
BaseClientInterface *StdIOSettings::createInterfaceWithProject(ProjectExplorer::Project *project) const
BaseClientInterface *StdIOSettings::createInterface(ProjectExplorer::Project *project) const
{
auto interface = new StdIOClientInterface;
interface->setCommandLine(command());