feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Mercurial: Modernize

Browse Source 
modernize-*

Change-Id: Ide38fa487e39e9363a48762d94b9ed3abed83337
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Alessandro Portale
2018-11-14 01:58:25 +01:00
parent 1950b38668
commit 20658d689f
10 changed files with 18 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/mercurial/mercurialplugin.cpp
View File

@@ -100,7 +100,7 @@ static const VcsBaseSubmitEditorParameters submitEditorParameters = {
VcsBaseSubmitEditorParameters::DiffFiles
};
MercurialPlugin *MercurialPlugin::m_instance = 0;
MercurialPlugin *MercurialPlugin::m_instance = nullptr;
MercurialPlugin::MercurialPlugin()
{
@@ -132,10 +132,9 @@ bool MercurialPlugin::initialize(const QStringList & /* arguments */, QString *
const auto describeFunc = [this](const QString &source, const QString &id) {
m_client->view(source, id);
};
const int editorCount = sizeof(editorParameters)/sizeof(editorParameters[0]);
const auto widgetCreator = []() { return new MercurialEditorWidget; };
for (int i = 0; i < editorCount; i++)
new VcsEditorFactory(editorParameters + i, widgetCreator, describeFunc, this);
for (auto editor : editorParameters)
new VcsEditorFactory(&editor, widgetCreator, describeFunc, this);
new VcsSubmitEditorFactory(&submitEditorParameters,
[]() { return new CommitEditor(&submitEditorParameters); }, this);
@@ -514,7 +513,7 @@ void MercurialPlugin::showCommitWidget(const QList<VcsBaseClient::StatusItem> &s
}
QTC_ASSERT(qobject_cast<CommitEditor *>(editor), return);
CommitEditor *commitEditor = static_cast<CommitEditor *>(editor);
auto commitEditor = static_cast<CommitEditor *>(editor);
setSubmitEditor(commitEditor);
connect(commitEditor, &VcsBaseSubmitEditor::diffSelectedFiles,
@@ -546,7 +545,7 @@ void MercurialPlugin::commitFromEditor()
bool MercurialPlugin::submitEditorAboutToClose()
{
CommitEditor *commitEditor = qobject_cast<CommitEditor *>(submitEditor());
auto commitEditor = qobject_cast<CommitEditor *>(submitEditor());
QTC_ASSERT(commitEditor, return true);
Core::IDocument *editorFile = commitEditor->document();
QTC_ASSERT(editorFile, return true);