feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMake: Fix configurations tab bar appearance

Browse Source 
A tab bar should span completely above the group that it "tabs", and
have no spacing to it. Otherwise there are funny visual artifacts, and
the visual correspondance is not clear.

Add an option for spacing to LayoutBuilder for that.

Change-Id: I5ca9dc713fff95599c9ec1cf90abe8473bc67c2a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
Eike Ziller
2022-02-15 10:41:13 +01:00
parent 282c3d0dab
commit 209ecc91a0
3 changed files with 41 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp
View File

@@ -339,16 +339,18 @@ CMakeBuildSettingsWidget::CMakeBuildSettingsWidget(CMakeBuildConfiguration *bc)
qmlDebugAspect
},
m_warningMessageLabel,
Space(10),
Row{m_kitConfiguration, m_configurationStates},
Group {
cmakeConfiguration,
Row {
bc->aspect<InitialCMakeArgumentsAspect>(),
bc->aspect<AdditionalCMakeOptionsAspect>()
},
m_reconfigureButton,
}
m_kitConfiguration,
Column {
m_configurationStates,
Group {
cmakeConfiguration,
Row {
bc->aspect<InitialCMakeArgumentsAspect>(),
bc->aspect<AdditionalCMakeOptionsAspect>()
},
m_reconfigureButton,
}
}.setSpacing(0)
}.attachTo(details, false);
updateAdvancedCheckBox();