From 20a3eae86f26ac10f4d1f5b3dca98d950e70cd51 Mon Sep 17 00:00:00 2001 From: Oswald Buddenhagen Date: Wed, 9 Dec 2020 18:33:15 +0100 Subject: [PATCH] fix memory leak in AndroidSdkDownloader::extractSdk() put the process on the stack, so we don't need (and fail) to free it. while at it, remove the pointless close() call. amends f46099d2. Change-Id: I4025691bebf2899efe006ee83012aefbb8797a64 Reviewed-by: Assam Boudjelthia --- src/plugins/android/androidsdkdownloader.cpp | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/plugins/android/androidsdkdownloader.cpp b/src/plugins/android/androidsdkdownloader.cpp index 9e0a87a0185..b4ccb6412aa 100644 --- a/src/plugins/android/androidsdkdownloader.cpp +++ b/src/plugins/android/androidsdkdownloader.cpp @@ -118,14 +118,13 @@ bool AndroidSdkDownloader::extractSdk(const QString &jdkPath, const QString &sdk } } - QProcess *jarExtractProc = new QProcess(); - jarExtractProc->setWorkingDirectory(sdkExtractPath); + QProcess jarExtractProc; + jarExtractProc.setWorkingDirectory(sdkExtractPath); QString jarCmdPath(jdkPath + "/bin/jar"); - jarExtractProc->start(jarCmdPath, {"xf", m_sdkFilename}); - jarExtractProc->waitForFinished(); - jarExtractProc->close(); + jarExtractProc.start(jarCmdPath, {"xf", m_sdkFilename}); + jarExtractProc.waitForFinished(); - return jarExtractProc->exitCode() ? false : true; + return jarExtractProc.exitCode() ? false : true; } bool AndroidSdkDownloader::verifyFileIntegrity()