feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Fix missing KitManager::kitUpdated() emission

Browse Source 
Amends a503c00fd4.

Fixes: QTCREATORBUG-22722
Change-Id: I17cca6d2c5c0ef4af2b4c77db6c926dc6ae8fd61
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Christian Kandeler
2019-07-17 14:56:34 +02:00
parent 32ac159ce6
commit 20ef53a346
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/projectexplorer/kitmanager.h
View File

@@ -55,7 +55,7 @@ class KitAspectWidget;
class KitManager; class KitManager;
namespace Internal { namespace Internal {
class KitModel; class KitManagerConfigWidget;
} // namespace Internal } // namespace Internal
/** /**
@@ -220,7 +220,7 @@ private:
friend class ProjectExplorerPlugin; // for constructor friend class ProjectExplorerPlugin; // for constructor
friend class Kit; friend class Kit;
friend class Internal::KitModel; friend class Internal::KitManagerConfigWidget;
friend class KitAspect; // for notifyAboutUpdate and self-registration friend class KitAspect; // for notifyAboutUpdate and self-registration
}; };

1
src/plugins/projectexplorer/kitmanagerconfigwidget.cpp
View File

@@ -172,6 +172,7 @@ void KitManagerConfigWidget::apply()
const auto copyIntoKit = [this](Kit *k) { k->copyFrom(m_modifiedKit.get()); }; const auto copyIntoKit = [this](Kit *k) { k->copyFrom(m_modifiedKit.get()); };
if (m_kit) { if (m_kit) {
copyIntoKit(m_kit); copyIntoKit(m_kit);
KitManager::notifyAboutUpdate(m_kit);
} else { } else {
m_isRegistering = true; m_isRegistering = true;
m_kit = KitManager::registerKit(copyIntoKit); m_kit = KitManager::registerKit(copyIntoKit);