feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Git: Pass CommitData by reference

Browse Source 
It is used for both input and output, the pointer is assumed
to be valid

Change-Id: Iad9a82dfb5ea4850584d4da848076699cddd23c2
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
This commit is contained in:
Orgad Shaneh
2013-04-30 21:32:24 +03:00
committed by Orgad Shaneh
parent 06da25f610
commit 20f1208e0f
4 changed files with 21 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/plugins/git/gitclient.cpp
+18 -18
View File
@@ -2019,10 +2019,10 @@ QString GitClient::gitBinaryPath(bool *ok, QString *errorMessage) const
bool GitClient::getCommitData(const QString &workingDirectory, bool GitClient::getCommitData(const QString &workingDirectory,
QString *commitTemplate, QString *commitTemplate,
CommitData *commitData, CommitData &commitData,
QString *errorMessage) QString *errorMessage)
{ {
commitData->clear(); commitData.clear();
// Find repo // Find repo
const QString repoDirectory = GitClient::findRepositoryForDirectory(workingDirectory); const QString repoDirectory = GitClient::findRepositoryForDirectory(workingDirectory);
@@ -2031,7 +2031,7 @@ bool GitClient::getCommitData(const QString &workingDirectory,
return false; return false;
} }
commitData->panelInfo.repository = repoDirectory; commitData.panelInfo.repository = repoDirectory;
QString gitDir = findGitDirForRepository(repoDirectory); QString gitDir = findGitDirForRepository(repoDirectory);
if (gitDir.isEmpty()) { if (gitDir.isEmpty()) {
@@ -2046,7 +2046,7 @@ bool GitClient::getCommitData(const QString &workingDirectory,
case StatusChanged: case StatusChanged:
break; break;
case StatusUnchanged: case StatusUnchanged:
if (commitData->commitType == AmendCommit) // amend might be run just for the commit message if (commitData.commitType == AmendCommit) // amend might be run just for the commit message
break; break;
*errorMessage = msgNoChangedFiles(); *errorMessage = msgNoChangedFiles();
return false; return false;
@@ -2062,39 +2062,39 @@ bool GitClient::getCommitData(const QString &workingDirectory,
// D deleted_file // D deleted_file
// ?? untracked_file // ?? untracked_file
if (status != StatusUnchanged) { if (status != StatusUnchanged) {
if (!commitData->parseFilesFromStatus(output)) { if (!commitData.parseFilesFromStatus(output)) {
*errorMessage = msgParseFilesFailed(); *errorMessage = msgParseFilesFailed();
return false; return false;
} }
// Filter out untracked files that are not part of the project // Filter out untracked files that are not part of the project
QStringList untrackedFiles = commitData->filterFiles(UntrackedFile); QStringList untrackedFiles = commitData.filterFiles(UntrackedFile);
VcsBase::VcsBaseSubmitEditor::filterUntrackedFilesOfProject(repoDirectory, &untrackedFiles); VcsBase::VcsBaseSubmitEditor::filterUntrackedFilesOfProject(repoDirectory, &untrackedFiles);
QList<CommitData::StateFilePair> filteredFiles; QList<CommitData::StateFilePair> filteredFiles;
QList<CommitData::StateFilePair>::const_iterator it = commitData->files.constBegin(); QList<CommitData::StateFilePair>::const_iterator it = commitData.files.constBegin();
for ( ; it != commitData->files.constEnd(); ++it) { for ( ; it != commitData.files.constEnd(); ++it) {
if (it->first == UntrackedFile && !untrackedFiles.contains(it->second)) if (it->first == UntrackedFile && !untrackedFiles.contains(it->second))
continue; continue;
filteredFiles.append(*it); filteredFiles.append(*it);
} }
commitData->files = filteredFiles; commitData.files = filteredFiles;
if (commitData->files.isEmpty() && commitData->commitType != AmendCommit) { if (commitData.files.isEmpty() && commitData.commitType != AmendCommit) {
*errorMessage = msgNoChangedFiles(); *errorMessage = msgNoChangedFiles();
return false; return false;
} }
} }
commitData->commitEncoding = readConfigValue(workingDirectory, QLatin1String("i18n.commitEncoding")); commitData.commitEncoding = readConfigValue(workingDirectory, QLatin1String("i18n.commitEncoding"));
// Get the commit template or the last commit message // Get the commit template or the last commit message
switch (commitData->commitType) { switch (commitData.commitType) {
case AmendCommit: { case AmendCommit: {
// Amend: get last commit data as "SHA1<tab>author<tab>email<tab>message". // Amend: get last commit data as "SHA1<tab>author<tab>email<tab>message".
QStringList args(QLatin1String("log")); QStringList args(QLatin1String("log"));
args << QLatin1String("--max-count=1") << QLatin1String("--pretty=format:%h\t%an\t%ae\t%B"); args << QLatin1String("--max-count=1") << QLatin1String("--pretty=format:%h\t%an\t%ae\t%B");
QTextCodec *codec = QTextCodec::codecForName(commitData->commitEncoding.toLocal8Bit()); QTextCodec *codec = QTextCodec::codecForName(commitData.commitEncoding.toLocal8Bit());
const Utils::SynchronousProcessResponse sp = synchronousGit(repoDirectory, args, 0, codec); const Utils::SynchronousProcessResponse sp = synchronousGit(repoDirectory, args, 0, codec);
if (sp.result != Utils::SynchronousProcessResponse::Finished) { if (sp.result != Utils::SynchronousProcessResponse::Finished) {
*errorMessage = tr("Cannot retrieve last commit data of repository \"%1\".").arg(repoDirectory); *errorMessage = tr("Cannot retrieve last commit data of repository \"%1\".").arg(repoDirectory);
@@ -2102,15 +2102,15 @@ bool GitClient::getCommitData(const QString &workingDirectory,
} }
QStringList values = sp.stdOut.split(QLatin1Char('\t')); QStringList values = sp.stdOut.split(QLatin1Char('\t'));
QTC_ASSERT(values.size() >= 4, return false); QTC_ASSERT(values.size() >= 4, return false);
commitData->amendSHA1 = values.takeFirst(); commitData.amendSHA1 = values.takeFirst();
commitData->panelData.author = values.takeFirst(); commitData.panelData.author = values.takeFirst();
commitData->panelData.email = values.takeFirst(); commitData.panelData.email = values.takeFirst();
*commitTemplate = values.join(QLatin1String("\t")); *commitTemplate = values.join(QLatin1String("\t"));
break; break;
} }
case SimpleCommit: { case SimpleCommit: {
commitData->panelData.author = readConfigValue(workingDirectory, QLatin1String("user.name")); commitData.panelData.author = readConfigValue(workingDirectory, QLatin1String("user.name"));
commitData->panelData.email = readConfigValue(workingDirectory, QLatin1String("user.email")); commitData.panelData.email = readConfigValue(workingDirectory, QLatin1String("user.email"));
// Commit: Get the commit template // Commit: Get the commit template
QDir gitDirectory(gitDir); QDir gitDirectory(gitDir);
QString templateFilename = gitDirectory.absoluteFilePath(QLatin1String("MERGE_MSG")); QString templateFilename = gitDirectory.absoluteFilePath(QLatin1String("MERGE_MSG"));
src/plugins/git/gitclient.h
+1 -1
View File
@@ -262,7 +262,7 @@ public:
QString readConfigValue(const QString &workingDirectory, const QString &configVar) const; QString readConfigValue(const QString &workingDirectory, const QString &configVar) const;
bool getCommitData(const QString &workingDirectory, QString *commitTemplate, bool getCommitData(const QString &workingDirectory, QString *commitTemplate,
CommitData *commitData, QString *errorMessage); CommitData &commitData, QString *errorMessage);
bool addAndCommit(const QString &workingDirectory, bool addAndCommit(const QString &workingDirectory,
const GitSubmitEditorPanelData &data, const GitSubmitEditorPanelData &data,
src/plugins/git/gitplugin.cpp
+1 -1
View File
@@ -897,7 +897,7 @@ void GitPlugin::startCommit(CommitType commitType)
QString errorMessage, commitTemplate; QString errorMessage, commitTemplate;
CommitData data(commitType); CommitData data(commitType);
if (!m_gitClient->getCommitData(state.topLevel(), &commitTemplate, &data, &errorMessage)) { if (!m_gitClient->getCommitData(state.topLevel(), &commitTemplate, data, &errorMessage)) {
VcsBase::VcsBaseOutputWindow::instance()->append(errorMessage); VcsBase::VcsBaseOutputWindow::instance()->append(errorMessage);
return; return;
} }
src/plugins/git/gitsubmiteditor.cpp
+1 -1
View File
@@ -164,7 +164,7 @@ void GitSubmitEditor::updateFileModel()
GitClient *client = GitPlugin::instance()->gitClient(); GitClient *client = GitPlugin::instance()->gitClient();
QString errorMessage, commitTemplate; QString errorMessage, commitTemplate;
CommitData data(m_commitType); CommitData data(m_commitType);
if (client->getCommitData(m_workingDirectory, &commitTemplate, &data, &errorMessage)) { if (client->getCommitData(m_workingDirectory, &commitTemplate, data, &errorMessage)) {
setCommitData(data); setCommitData(data);
} else { } else {
VcsBase::VcsBaseOutputWindow::instance()->append(errorMessage); VcsBase::VcsBaseOutputWindow::instance()->append(errorMessage);