feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlProfiler: Rename QmlEvent::startTime to "timestamp"

Browse Source 
As many events are instantaneous and we're going to drop the duration
property soon, this is more fitting.

Change-Id: I6e13dd076a5b9df16aed44bf9f631ea5760e9cbf
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
This commit is contained in:
Ulf Hermann
2016-04-28 15:40:02 +02:00
parent a53780924d
commit 215c0533d2
12 changed files with 55 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/plugins/qmlprofiler/qmlprofilerstatisticsmodel.cpp
View File

@@ -188,8 +188,8 @@ void QmlProfilerStatisticsModel::loadData(qint64 rangeStart, qint64 rangeEnd)
continue;
if (checkRanges) {
if ((event->startTime() + event->duration() < rangeStart)
|| (event->startTime() > rangeEnd))
if ((event->timestamp() + event->duration() < rangeStart)
|| (event->timestamp() > rangeEnd))
continue;
}
@@ -208,17 +208,17 @@ void QmlProfilerStatisticsModel::loadData(qint64 rangeStart, qint64 rangeEnd)
durations[event->typeIndex()].append(event->duration());
// qml time computation
if (event->startTime() > lastEndTime) { // assume parent event if starts before last end
if (event->timestamp() > lastEndTime) { // assume parent event if starts before last end
qmlTime += event->duration();
lastEndTime = event->startTime() + event->duration();
lastEndTime = event->timestamp() + event->duration();
}
//
// binding loop detection
//
const QmlEvent *potentialParent = callStack.top();
while (potentialParent && !(potentialParent->startTime() + potentialParent->duration() >
event->startTime())) {
while (potentialParent && !(potentialParent->timestamp() + potentialParent->duration() >
event->timestamp())) {
callStack.pop();
potentialParent = callStack.top();
}
@@ -362,14 +362,14 @@ void QmlProfilerStatisticsParentsModel::loadData()
continue;
// level computation
if (endtimesPerLevel[level] > event.startTime()) {
if (endtimesPerLevel[level] > event.timestamp()) {
level++;
} else {
while (level > Constants::QML_MIN_LEVEL &&
endtimesPerLevel[level-1] <= event.startTime())
endtimesPerLevel[level-1] <= event.timestamp())
level--;
}
endtimesPerLevel[level] = event.startTime() + event.duration();
endtimesPerLevel[level] = event.timestamp() + event.duration();
int parentTypeIndex = -1;
if (level > Constants::QML_MIN_LEVEL && lastParent.contains(level-1))
@@ -424,14 +424,14 @@ void QmlProfilerStatisticsChildrenModel::loadData()
continue;
// level computation
if (endtimesPerLevel[level] > event.startTime()) {
if (endtimesPerLevel[level] > event.timestamp()) {
level++;
} else {
while (level > Constants::QML_MIN_LEVEL &&
endtimesPerLevel[level-1] <= event.startTime())
endtimesPerLevel[level-1] <= event.timestamp())
level--;
}
endtimesPerLevel[level] = event.startTime() + event.duration();
endtimesPerLevel[level] = event.timestamp() + event.duration();
int parentId = -1;