feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LocatorFilter classes: Use more linkForEditor

Browse Source 
Limit the usage of ambiguous internalData.

Change-Id: Ice67884b9fb2ff303939cd5998c6e80453e82530
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Jarek Kobus
2023-02-22 19:51:22 +01:00
parent 34fd28327d
commit 215f79f580
11 changed files with 61 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/cppeditor/cppmodelmanager.cpp
View File

@@ -572,12 +572,9 @@ void CppModelManager::findUnusedFunctions(const FilePath &folder)
return entry.displayName.startsWith(prefix); })) {
continue;
}
Link link;
if (entry.internalData.canConvert<Link>())
link = qvariant_cast<Link>(entry.internalData);
else if (const auto item = qvariant_cast<IndexItem::Ptr>(entry.internalData))
link = Link(item->filePath(), item->line(), item->column());
if (!entry.linkForEditor)
continue;
const Link link = *entry.linkForEditor;
if (link.hasValidTarget() && link.targetFilePath.isReadableFile()
&& (folder.isEmpty() || link.targetFilePath.isChildOf(folder))
&& ProjectManager::projectForFile(link.targetFilePath)) {