From 21b8e10814e69e45b7ff1fbe793a92590ad5ebd9 Mon Sep 17 00:00:00 2001
From: Ivan Donchevskii <ivan.donchevskii@qt.io>
Date: Wed, 29 Nov 2017 10:31:22 +0100
Subject: [PATCH] Clang: Fix FilePathView constructor

Do not keep pointer of a temporary object.

Change-Id: I5251c7dbc8581be96afaa947e1a58adaeb0b17e3
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
---
 src/libs/clangsupport/filepathview.h       | 5 +++--
 src/libs/clangsupport/nativefilepathview.h | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/libs/clangsupport/filepathview.h b/src/libs/clangsupport/filepathview.h
index 5d62cec7edc..a0d129cec65 100644
--- a/src/libs/clangsupport/filepathview.h
+++ b/src/libs/clangsupport/filepathview.h
@@ -45,8 +45,9 @@ public:
     {
     }
 
-    template <typename String>
-    explicit FilePathView(String filePath)
+    template <typename String,
+              typename = std::enable_if_t<std::is_lvalue_reference<String>::value>>
+    explicit FilePathView(String &&filePath)
         : FilePathView(filePath.data(), filePath.size())
     {
     }
diff --git a/src/libs/clangsupport/nativefilepathview.h b/src/libs/clangsupport/nativefilepathview.h
index c2f2246c492..6b451d1d538 100644
--- a/src/libs/clangsupport/nativefilepathview.h
+++ b/src/libs/clangsupport/nativefilepathview.h
@@ -44,8 +44,9 @@ public:
     {
     }
 
-    template <typename String>
-    explicit NativeFilePathView(String filePath)
+    template <typename String,
+              typename = std::enable_if_t<std::is_lvalue_reference<String>::value>>
+    explicit NativeFilePathView(String &&filePath)
         : NativeFilePathView(filePath.data(), filePath.size())
     {
     }